<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, 13 Aug 2015 at 16:27 Ladislav Thon <<a href="mailto:lthon@redhat.com">lthon@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> The approach I took was to add the warnings to the describe-migration<br>
> op, and when running the migrate op make the describe-migration<br>
> operation the first step in the composite, so the output looks like<br>
> this: <a href="http://pastebin.com/B01KNAHX" rel="noreferrer" target="_blank">http://pastebin.com/B01KNAHX</a><br>
<br>
The fact that it's a composite operation makes the output a bit cryptic<br>
(step-X?), but otherwise I think it's actually good.<br>
<br>
I guess that only handling the warnings in :describe-migration makes the<br>
implementation easier (not sure?) and printing :describe-migration as a<br>
part of :migrate makes sense too, precisely because it shows the steps<br>
that are performed.<br>
<br>
So my only objection would be those cryptic "step-X" names, but I guess<br>
that we can live with that (if all :migrate operations took the same<br>
approach; inconsistency wouldn't really help here).<br></blockquote><div><br></div><div>That is because this is implemented as a composite operation, AFAIK there is lots of special handing for composite ops, so I don't think we want to be implementing our own one with different output just for this case. </div><div><br></div><div>I could be wrong though, this is not really my area, Brian will know more.</div><div><br></div><div>Stuart</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
LT<br>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
</blockquote></div></div>