<div dir="ltr">I don't know anything about PowerShell scripting, so I'm okay with it as long as the behavior is the same.<div><br></div><div>The one concern I do have is with the --background bit. We do create a PID file for the LAUNCH_IN_BACKGROUND, but it doesn't make sense to me why we do. That's off topic for this though :) We don't seem to use these files for anything so I just don't see the point in creating them.</div><div><br></div><div>Anyway, the whole PID thing I think needs to be thought about. With the current behavior in the bash scripts it doesn't exit until the background process has been stopped. I can't really tell what the PS scripts do with the launch in background. Does the script exit or pause until the process is exited?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 29, 2015 at 8:29 AM, Tomaž Cerar <span dir="ltr"><<a href="mailto:tomaz.cerar@gmail.com" target="_blank">tomaz.cerar@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Hey guys,<br><br><br></div>just heads up, I've managed to prepare[1] all powershell scripts to replace the aging .bat ones.<br><br></div>New scripts unify most of the shared "code" that all scripts use by including common.ps1,<br></div><div>and each script only has the code that differs from common behavior they all share.<br><br></div><div>As result of move we now have much more reliable and faster scripts that share common code,<br></div><div>which helps with maintaining a lot.<br><br></div><div>New scripts (domain.ps1 & standalone.ps1) now support --background (also controllable via .conf.ps1) <br>option that runs the process in background and remembers its pid and as such add support for <br></div><div>feature that until now was only in *nix version of scripts.<br></div><div><div><br></div><div>I would like to propose this PR for inclusion to WildFly 10. As it doesn't alter any existing behavior<br></div><div>but just adds & improve the script experience on Windows.<br></div><div><br></div><div>As we get to test and verify that new scripts don't break/include any currently available option/action<br></div><div>I would also like to remove the batch scripts[2], so they would just do call out to their .ps1 counter parts.<br></div><div><br></div><div>Once this scripts get merged, I will send PR to also add PS scripts for WildFly full defined scripts, <br>given that most of the functionally is already in "common.ps1" new scripts will be just simple 5 liners [3]<br></div><div><br><br>--<br></div><div>tomaz<br></div><div><br><br>[1] <a href="https://github.com/wildfly/wildfly-core/pull/1118" target="_blank">https://github.com/wildfly/wildfly-core/pull/1118</a><br>[2] <a href="https://github.com/wildfly/wildfly-core/pull/1126" target="_blank">https://github.com/wildfly/wildfly-core/pull/1126</a><br>[3] <a href="https://github.com/ctomc/wildfly-core/blob/powershell/core-feature-pack/src/main/resources/content/bin/add-user.ps1" target="_blank">https://github.com/ctomc/wildfly-core/blob/powershell/core-feature-pack/src/main/resources/content/bin/add-user.ps1</a><br><br></div></div></div>
<br>_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>James R. Perkins</div><div>JBoss by Red Hat</div></div></div></div></div>
</div>