<div dir="ltr"><div><div>You are missing text description of the key you added. <br></div>They are usually stored in LocalDescriptions.properties of your module.<br></div>for infinispan subsystem that would probably be in <br>src/main/resources/org/jboss/as/clustering/infinispan/subsystem/LocalDescriptions.properties<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Oct 18, 2015 at 10:04 PM, Simon Paulger <span dir="ltr"><<a href="mailto:spaulger@codezen.co.uk" target="_blank">spaulger@codezen.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>Sorry for the delay in getting back to you all.</div><div><br></div><div>In terms of what I've developed, I have uploaded the development branch here: <a href="https://github.com/spaulg/wildfly/tree/feature/redis-support" target="_blank">https://github.com/spaulg/wildfly/tree/feature/redis-support</a>.</div><div><br></div><div>This includes all changes I've made, which I've recently merged in 10.0.0CR2. I know this won't be added to that release, but it means I can track against a stable and current branch.</div><div><br></div><div>Regarding Tristan's comment and Tomaz's reply for having subextensions of extensions, what I have developed simply matches the existing approach used by the Remote store. I have created a StoreBuilder, BuilderFactory and ResourceDefinition for the Redis store and registered this in to the XML reader/writer for the Infinispan subsystem. This means when the configuration has a redis-store tag as a cache store that has its own configuration attributes.</div><div><br></div><div>In terms of the cli/web and the changes that need to be made. I have made all the xsd changes and amending the xml reader/writer for the new store, however its failing unit tests with the error below. I'm not sure why.</div><div><br></div><div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span><font face="monospace, monospace">testDescribeHandler[8](org.jboss.as.clustering.infinispan.subsystem.SubsystemParsingTestCase) Time elapsed: 0.023 sec <<< ERROR!<br></font></span><span><font face="monospace, monospace">java.lang.RuntimeException: "WFLYCTL0158: Operation handler failed: java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key infinispan.local-cache.redis-store"<br></font></span><span><font face="monospace, monospace">at org.jboss.as.subsystem.test.SubsystemTestDelegate.validateDescriptionProviders(SubsystemTestDelegate.java:581)<br></font></span><span><font face="monospace, monospace">at org.jboss.as.subsystem.test.SubsystemTestDelegate.access$500(SubsystemTestDelegate.java:118)<br></font></span><span><font face="monospace, monospace">at org.jboss.as.subsystem.test.SubsystemTestDelegate$KernelServicesBuilderImpl.build(SubsystemTestDelegate.java:669)<br></font></span><span><font face="monospace, monospace">at org.jboss.as.clustering.infinispan.subsystem.SubsystemParsingTestCase.testDescribeHandler(SubsystemParsingTestCase.java:187)</font></span></blockquote>
</div><div><br></div><div>Kind regards,</div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
</blockquote><div>Simon</div>
</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On 8 October 2015 at 16:26, Brian Stansberry <span dir="ltr"><<a href="mailto:brian.stansberry@redhat.com" target="_blank">brian.stansberry@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">No, not really.<br>
<br>
Notions like that have come up a time or two, but I wouldn't say they<br>
are planned.<br>
<br>
This seems like primarily a module loading issue. The parent extension<br>
needs to be made aware of the presence of an external module so it can<br>
load classes from it and use those to extend its own management API.<br>
Those classes would implement an SPI provided by the parent extension.<br>
That SPI would be a mix of kernel stuff and stuff specific to the parent<br>
extension<br>
<br>
1) specific stuff: things like where "child extension" resources can be<br>
inserted into the parent tree<br>
<br>
2) kernel stuff: various support classes / SPIs that all such cases can<br>
use to make these things as consistent as possible.<br>
<div><div><br>
On 10/8/15 10:06 AM, Tristan Tarrant wrote:<br>
> Actually, let me expand on Simon's request, since this is something I've<br>
> wanted to have from WF: sub-extensions to extensions (or sub-subsystems).<br>
> For this particular use-case, a way for an extension (an Infinispan<br>
> Cache Store) to declare that it is a child of another extension<br>
> (Infinispan). The child extension would be responsible for<br>
> parsing/serializing its own section of the XML, service registration, etc.<br>
> Is this planned ?<br>
><br>
> Thanks<br>
><br>
> Tristan<br>
><br>
> On 08/10/2015 15:29, Tomaž Cerar wrote:<br>
>><br>
>> On Sat, Sep 26, 2015 at 11:12 PM, Simon Paulger <<a href="mailto:spaulger@codezen.co.uk" target="_blank">spaulger@codezen.co.uk</a><br>
>> <mailto:<a href="mailto:spaulger@codezen.co.uk" target="_blank">spaulger@codezen.co.uk</a>>> wrote:<br>
>><br>
>> I just want to re-iterate this to try and get it ready for the final<br>
>> Wildfly 10 release. In order to make Redis integration, what changes<br>
>> should I be making? In particular;<br>
>><br>
>> You are too late to get any new feature to 10, CRx build are just<br>
>> bugfixes of existing stuff and no new features are being added anymore.<br>
>><br>
>><br>
>> 1. xml reader/writer - should I be adding redis-store as a concrete<br>
>> xml tag?<br>
>> 2. persistence pom updates to add the redis jar dependency<br>
>> 3. xsd documentation updates<br>
>> 4. module configurations<br>
>> 5. jboss-cli - do I need to add a redis-store type to a cache<br>
>> container?<br>
>> 6. web management console - again redis-store type to a cache<br>
>> container?<br>
>><br>
>><br>
>> 1,3,5&6 are basically the same thing, you need to add support for<br>
>> redis-store to infinispan subsystem.<br>
>> When that is done correctly, cli is done as well.<br>
>> And once CLI part is done, you can access same stuff via mgmt REST api<br>
>> which console uses.<br>
>> In most cases console doesn't need changes for extra fields / resources,<br>
>> but if it does,<br>
>> you can send change to HAL project once all of the previous points are<br>
>> done and change is merged in WildFly master<br>
>><br>
>> for general docs about extending WildFly itself look at<br>
>> <a href="https://docs.jboss.org/author/display/WFLY10/Extending+WildFly" rel="noreferrer" target="_blank">https://docs.jboss.org/author/display/WFLY10/Extending+WildFly</a><br>
>><br>
>><br>
>><br>
>> 1 - 3 are done, 4 is in progress, however I am unclear on how to<br>
>> make 5 and 6 (can't find the code locations), and I also want steer<br>
>> on whether a concrete store type is needed or if the custom store<br>
>> should be the way to go, in which case I think only pom updates and<br>
>> module config is required.<br>
>><br>
>><br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> wildfly-dev mailing list<br>
>> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
>><br>
><br>
<br>
<br>
--<br>
</div></div><span><font color="#888888">Brian Stansberry<br>
Senior Principal Software Engineer<br>
JBoss by Red Hat<br>
</font></span><div><div>_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br></blockquote></div><br></div>