<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 20, 2016 at 5:01 PM, Michael Musgrove <span dir="ltr"><<a href="mailto:mmusgrov@redhat.com" target="_blank">mmusgrov@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Jan 20, 2016 at 4:45 PM, Tomasz Adamski <span dir="ltr"><<a href="mailto:tadamski@redhat.com" target="_blank">tadamski@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span>> A follow up question is, if we add javax.orb.api as module dependency (in<br>
> our wildfly transactions subsystem) then at runtime will we be using the<br>
> classes provided by openjdk-orb?<br>
<br>
</span>If we use openjdk-orb in jboss-modules environment we are sure that openjdk-orb is used as orb classes are not exported as system packages.<br></blockquote><div><br></div></span><div>Okay so we are covered in wildfly and EAP which is good to know.</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span><br>
> Is it the case that we cannot avoid this warning but<br>
> that we are safe provided at runtime we use the classes in the openjdk-orb<br>
> jar?<br>
<br>
</span>In standalone scenario it should work correctly too. I will look wheter the error is caused by jdeps tool behaviour or do we indeed have some unwanted runtime references to JDK.<br></blockquote><div><br></div></span><div>In a standalone scenario we are not using modules so the JVM would use rt.jar unless the user updates the bootclasspath. I do not see how it would be possible to avoid the jdeps warnings.</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span><br>
> We probably should rename the packages to avoid confusion. What do you think<br>
> Tomasz?<br>
<br>
</span>This can be done but I see one problem: openjdk-orb is a hg repository and we have possibility to synchronize it with JDK head if there are some changes in ORB code. I would have to script it somehow to preserve such possibility. But I agree that it will be nice to do.<br></blockquote><div><br></div></span><div>I agree it would be nice (but I guess not a must have).</div></div></div></div></blockquote><div><br></div><div>On second thoughts, for standalone usage it is a pain to have to tell the user that he must start the JVM with -Xbootclasspath/p:${openjdk-orb.jar} which might be a barrier to adoption for some users.</div><div><br></div><div>Mike</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>Mike </div><div><div class="h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
--<br>
Tomasz Adamski<br>
Software Engineer<br>
JBoss by Red Hat<br>
<br>
----- Oryginalna wiadomość -----<br>
> Od: "Jason Greene" <<a href="mailto:jason.greene@redhat.com" target="_blank">jason.greene@redhat.com</a>><br>
> Do: "Michael Musgrove" <<a href="mailto:mmusgrov@redhat.com" target="_blank">mmusgrov@redhat.com</a>><br>
> DW: "WildFly Dev" <<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a>>, "Tomasz Adamski" <<a href="mailto:tadamski@redhat.com" target="_blank">tadamski@redhat.com</a>><br>
> Wysłane: środa, 20 styczeń 2016 17:13:04<br>
> Temat: Re: [wildfly-dev] How to avoid depending on corba classes in rt.jar<br>
<span>><br>
> We probably should rename the packages to avoid confusion. What do you think<br>
> Tomasz?<br>
><br>
><br>
> > On Jan 20, 2016, at 10:07 AM, Michael Musgrove <<a href="mailto:mmusgrov@redhat.com" target="_blank">mmusgrov@redhat.com</a>> wrote:<br>
> ><br>
> > The narayana jts jar has dependencies on internal jdk orb classes. We test<br>
> > that it can work with the openjdk-orb by adding the openjdk-orb jar to the<br>
> > bootclasspath. However, jdeps -jdkinternals reports that we depend on<br>
> > internal JDK APIs. Is it the case that we cannot avoid this warning but<br>
> > that we are safe provided at runtime we use the classes in the openjdk-orb<br>
> > jar?<br>
> ><br>
> > A follow up question is, if we add javax.orb.api as module dependency (in<br>
> > our wildfly transactions subsystem) then at runtime will we be using the<br>
> > classes provided by openjdk-orb?<br>
> ><br>
> > Thanks,<br>
> > Mike<br>
> ><br>
> > --<br>
> > Michael Musgrove<br>
> > Transactions Team<br>
</span>> > e: <a href="mailto:mmusgrov@redhat.com" target="_blank">mmusgrov@redhat.com</a> <mailto:<a href="mailto:mmusgrov@redhat.com" target="_blank">mmusgrov@redhat.com</a>><br>
<div><div>> > t: <a href="tel:%2B44%20191%20243%200870" value="+441912430870" target="_blank">+44 191 243 0870</a><br>
> ><br>
> > Registered in England and Wales under Company Registration No. 03798903<br>
> > Directors: Michael Cunningham (US), Paul Hickey (Ireland), Matt Parson<br>
> > (US), Charles Peters (US)<br>
> ><br>
> > Michael Cunningham (US), Charles Peters (US), Matt Parson (US), Michael<br>
> > O'Neill(Ireland)<br>
> > _______________________________________________<br>
> > wildfly-dev mailing list<br>
> > <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
><br>
> --<br>
> Jason T. Greene<br>
> WildFly Lead / JBoss EAP Platform Architect<br>
> JBoss, a division of Red Hat<br>
><br>
><br>
</div></div></blockquote></div></div></div><div><div class="h5"><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div>Michael Musgrove</div><div>Transactions Team</div><div>e: <a href="mailto:mmusgrov@redhat.com" target="_blank">mmusgrov@redhat.com</a></div><div>t: <a href="tel:%2B44%20191%20243%200870" value="+441912430870" target="_blank">+44 191 243 0870</a></div><div><br></div><div>Registered in England and Wales under Company Registration No. 03798903</div><div>Directors: Michael Cunningham (US), Paul Hickey (Ireland), Matt Parson</div><div>(US), Charles Peters (US)</div><div><br></div><div>Michael Cunningham (US), Charles Peters (US), Matt Parson (US), Michael O'Neill(Ireland)</div></div></div>
</div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Michael Musgrove</div><div>Transactions Team</div><div>e: <a href="mailto:mmusgrov@redhat.com" target="_blank">mmusgrov@redhat.com</a></div><div>t: +44 191 243 0870</div><div><br></div><div>Registered in England and Wales under Company Registration No. 03798903</div><div>Directors: Michael Cunningham (US), Paul Hickey (Ireland), Matt Parson</div><div>(US), Charles Peters (US)</div><div><br></div><div>Michael Cunningham (US), Charles Peters (US), Matt Parson (US), Michael O'Neill(Ireland)</div></div></div>
</div></div>