<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 2016-02-11 2:55 PM, Stuart Douglas
wrote:<br>
</div>
<blockquote
cite="mid:CAAoo=c6kmjhxu=_7fTBuxExRpuST9a4bywxbeL+X2uA04U3Skg@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<br>
<div class="gmail_quote">
<div dir="ltr">On Fri, 12 Feb 2016 at 06:42 James Perkins <<a
moz-do-not-send="true" href="mailto:jperkins@redhat.com"><a class="moz-txt-link-abbreviated" href="mailto:jperkins@redhat.com">jperkins@redhat.com</a></a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I don't recall the previous discussion, but
is there a reason we couldn't just use a JBoss module with
a different slot?</div>
</blockquote>
<div><br>
</div>
<div>Nah, the issue is that these classes need to be
referenced by the deployment and hibernate, so whatever
version hibernate uses has to be the one exposed to the
deployment.<br>
</div>
</div>
</div>
</blockquote>
Can't we require that that alternative module is specified as a
dependency for the hibernate deployments?<br>
<br>
It does put the onus on the user but we already end up having to
specify a few things for hibernate anyway.<br>
<br>
Fernando<br>
<br>
<br>
<blockquote
cite="mid:CAAoo=c6kmjhxu=_7fTBuxExRpuST9a4bywxbeL+X2uA04U3Skg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>Stuart<br>
</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Feb 11, 2016 at 8:03 AM,
Scott Marlow <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:smarlow@redhat.com" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:smarlow@redhat.com">smarlow@redhat.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">As
previously discussed, Hibernate applications need
access to the<br>
Javassist runtime classes (see example [1] enhanced
application entity<br>
if you didn't know this :). A proposal was discussed
on the<br>
hibernate-dev mailing list that I think is the best
short term solution.<br>
I wanted to raise this issue here also, as I would
like to later<br>
create a pull request to bring in a new Hibernate ORM
that includes this<br>
change. So, getting early feedback before we create
JIRAs for the work,<br>
is important.<br>
<br>
The proposal is to private package (or shade), the
Javassist classes, so<br>
that Hibernate ORM has its own copy of the Javassist
classes. On<br>
WildFly, we still would include Javassist for the
other components that<br>
use it and for Hibernate applications that have
"build-time enhanced<br>
entity classes" by an earlier Hibernate release.<br>
<br>
One downside of this change is that Hibernate
applications cannot easily<br>
switch to a different version of the Javassist
classes.<br>
<br>
Another downside is that applications that depend on
an older Hibernate<br>
ORM version that includes "build-time enhanced entity
classes", will<br>
need to be cracked open, to add dependencies on the
Javassist module<br>
(since we will stop automatically adding Javassist to
JPA application<br>
deployments).<br>
<br>
The advantage of this change, is that Hibernate
applications can include<br>
their own version of Javassist.<br>
<br>
This will also have an impact on Hibernate build-time
enhancing of<br>
entity classes (e.g. enhanced bytecode will no longer
depend on the<br>
public Javassist classes).<br>
<br>
Scott<br>
<br>
[1] <a moz-do-not-send="true"
href="https://gist.github.com/scottmarlow/dc7ebfea654984f84e2e"
rel="noreferrer" target="_blank">https://gist.github.com/scottmarlow/dc7ebfea654984f84e2e</a><br>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:wildfly-dev@lists.jboss.org"
target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/wildfly-dev"
rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
</div>
<div class="gmail_extra">-- <br>
<div>
<div dir="ltr">
<div>
<div dir="ltr">
<div>James R. Perkins</div>
<div>JBoss by Red Hat</div>
</div>
</div>
</div>
</div>
</div>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/wildfly-dev"
rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></blockquote>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
wildfly-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/wildfly-dev">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></pre>
</blockquote>
<br>
</body>
</html>