<div dir="ltr"><div>Is there any reason why we can't update to the latest version of Javassist? I know this does not prevent similar issues in future, but we should probably be using the most recent version if there is no reason not to.<br><br></div><div>My issue with <a href="https://github.com/wildfly/wildfly/pull/8474">https://github.com/wildfly/wildfly/pull/8474</a> is that in general we should not be using export="true", as it makes it impossible to exclude the dependency using jboss-deployment-structure.xml. As a result I don't really see how this PR is an improvement, as it goes from the javassist deployment being added directly to the deployment to it being added indirectly via an export.<br></div><div><br></div>Stuart<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 13, 2017 at 11:03 PM, Sanne Grinovero <span dir="ltr"><<a href="mailto:sanne@hibernate.org" target="_blank">sanne@hibernate.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<br>
Scott sent a nice PR to Wildfly a while back to fix the problem:<br>
- <a href="https://github.com/wildfly/wildfly/pull/9305" rel="noreferrer" target="_blank">https://github.com/wildfly/<wbr>wildfly/pull/9305</a><br>
<br>
It wasn't merged, I guess it's not a priority for WildFly but let me<br>
clarify that without such fixes it's impossible for people to use<br>
newer versions of Hibernate ORM on WildFly, and I suspect lots of pain<br>
as well for other libraries using Javassist.<br>
<br>
There's quite some people in the Hibernate community who expressed<br>
interest in using a not-so-stale version as the one which is typically<br>
available in the latest stable release of WildFly.<br>
<br>
To make this happen, all Hibernate projects are now publishing<br>
"WildFly modules" which can be easily downloaded as additional drop-in<br>
layer.<br>
Granted these are not for everyone but we get good feedback from the<br>
power users interested, and not least this allows us to develop all<br>
our projects while regularly testing integration with WildFly, making<br>
sure that the eventual integration goes smoother.<br>
<br>
The current problem is that the WildFly JPADependencyProcessor adds<br>
the wrong version of javassist to the deployments, and there's no way<br>
for us to prevent this or override this, making it impossible to use a<br>
recent version of Hibernate ORM as it requires a newer version.<br>
- <a href="https://github.com/wildfly/wildfly/blob/6b61a6003f704221f66dcd9f418bcb7af88fb9ab/jpa/subsystem/src/main/java/org/jboss/as/jpa/processor/JPADependencyProcessor.java#L95" rel="noreferrer" target="_blank">https://github.com/wildfly/<wbr>wildfly/blob/<wbr>6b61a6003f704221f66dcd9f418bcb<wbr>7af88fb9ab/jpa/subsystem/src/<wbr>main/java/org/jboss/as/jpa/<wbr>processor/<wbr>JPADependencyProcessor.java#<wbr>L95</a><br>
<br>
We'd highly appreciate if that PR could be merged? Including on<br>
product branches please, as enforcing a dependency which is neither<br>
needed nor desired is going to break a long list of other frameworks<br>
as well.<br>
<br>
Thanks,<br>
Sanne<br>
______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/wildfly-dev</a><br>
</blockquote></div><br></div>