<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 7, 2017 at 9:23 PM, Tomaž Cerar <span dir="ltr"><<a href="mailto:tomaz.cerar@gmail.com" target="_blank">tomaz.cerar@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div>Well I am all for using new packages and don't mind mixing them.<br><br></div>I consider org.jboss.as.testsuite.* packages as legacy and ridden with problems as they usually contain most problematic testsuite code that should need deeper look into,<br>I know that is not 100% accurate but still holds up to a point.<br></div></div></div></div></blockquote><div><br></div><div>That is because 99% of the tests are in <a href="http://org.jboss.as">org.jboss.as</a>, so of course it has the problematic tests as well.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div></div><br></div>Said all that, I do agree that if same test functionality already exists in either parent package it should stay there,<br></div>or if new stuff is added and author wants to add it to new package, it should also result in migrating all other classes into same package.<br></div></blockquote><div><br></div><div>Moving existing tests to org.wildfly can be problematic, as is makes backporting more difficult.<br><br></div><div>Stuart<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><br><br><div>--<br></div><div>tomaz<br></div><div><br></div></div></div></div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 6, 2017 at 11:12 PM, Stuart Douglas <span dir="ltr"><<a href="mailto:stuart.w.douglas@gmail.com" target="_blank">stuart.w.douglas@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Yes, I am only talking about existing test suite modules that are already using the <a href="http://org.jboss.as" target="_blank">org.jboss.as</a> package.<br><br></div>For example in integration/basic we now have 'org.wildfly.test.integration.<wbr>ejb' and 'org.jboss.as.test.integration<wbr>.ejb', which are logically the same package, but now you have two different places to look for ejb tests.<span class="m_6922666366855976311HOEnZb"><font color="#888888"><br><br></font></span></div><span class="m_6922666366855976311HOEnZb"><font color="#888888">Stuart<br></font></span></div><div class="m_6922666366855976311HOEnZb"><div class="m_6922666366855976311h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 6, 2017 at 8:06 PM, Kabir Khan <span dir="ltr"><<a href="mailto:kabir.khan@jboss.com" target="_blank">kabir.khan@jboss.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If you are specifically talking about the testsuite/elytron module, I believe we can leave those under org.wildfly.test.integration.e<wbr>lytron. Stuart's gripe, as I read it, is mixing of the two packages within a module.<br>
<div class="m_6922666366855976311m_1787528336105685547HOEnZb"><div class="m_6922666366855976311m_1787528336105685547h5">> On 6 Apr 2017, at 07:56, Josef Cacek <<a href="mailto:jcacek@redhat.com" target="_blank">jcacek@redhat.com</a>> wrote:<br>
><br>
> I think, Tomaz should share his view (CC-ing)<br>
><br>
> During our discussion related to Elytron testing, his preference was to use org.wildfly package names.<br>
><br>
> -- Josef<br>
><br>
> ----- Original Message -----<br>
>> From: "Stuart Douglas" <<a href="mailto:stuart.w.douglas@gmail.com" target="_blank">stuart.w.douglas@gmail.com</a>><br>
>> To: <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
>> Sent: Monday, April 3, 2017 3:45:59 AM<br>
>> Subject: [wildfly-dev] Mixing <a href="http://org.jboss.as" rel="noreferrer" target="_blank">org.jboss.as</a> and org.wildfly packages<br>
>><br>
>> Hi,<br>
>><br>
>> So this is a minor issue, but it annoys me so I thought I would see what<br>
>> other people think about it. In the test suite I have noticed that some new<br>
>> code is being added under the org.wildfly package, even though all the<br>
>> existing code is still under <a href="http://org.jboss.as" rel="noreferrer" target="_blank">org.jboss.as</a> .<br>
>><br>
>> I don't think this is a good idea, as it means there is two potential places<br>
>> to look for something, with no real reason why something is in a particular<br>
>> package other than the date it was added.<br>
>><br>
>> I propose that we move all the org.wildfly code into <a href="http://org.jboss.as" rel="noreferrer" target="_blank">org.jboss.as</a> to keep<br>
>> everything consistent (moving everything to org.wildfly would also be an<br>
>> option, but it has implications for backporting and has the potential to<br>
>> create a lot more work).<br>
>><br>
>> Does anyone have any objections to this? If not I will prepare some PR's.<br>
>><br>
>> Stuart<br>
>><br>
>> ______________________________<wbr>_________________<br>
>> wildfly-dev mailing list<br>
>> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/wildfly-dev</a><br>
> ______________________________<wbr>_________________<br>
> wildfly-dev mailing list<br>
> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/wildfly-dev</a><br>
<br>
<br>
______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/wildfly-dev</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/wildfly-dev</a><br></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>