<div dir="ltr">There's no way we can have tests for every feature that every project brings into WildFly.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 14, 2017 at 1:00 AM, Carlo de Wolf <span dir="ltr"><<a href="mailto:cdewolf@redhat.com" target="_blank">cdewolf@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">These form of conflicts must be guarded in a test(suite) that is part of WildFly release criteria.<span class="HOEnZb"><font color="#888888"><br>
<br>
Carlo</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On 08/12/2017 11:44 AM, Sanne Grinovero wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks James! I've sent a PR to restore the previous version.<br>
<br>
I'll be checking some more cross-project dependency requirements next weeek.<br>
<br>
On 12 August 2017 at 01:08, James Perkins <<a href="mailto:jperkins@redhat.com" target="_blank">jperkins@redhat.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
It looks like it came in as part of<br>
<a href="https://issues.jboss.org/browse/WFLY-7908" rel="noreferrer" target="_blank">https://issues.jboss.org/brows<wbr>e/WFLY-7908</a>. I'm personally not a big fan of<br>
these sweeping version updates like this for this exact reason. We've had<br>
issues with this type of thing before and I do think we need a better<br>
approach.<br>
<br>
IMO we can definitely downgrade this. I also see no other modules that<br>
depend on it either.<br>
<br>
On Fri, Aug 11, 2017 at 2:43 PM, Sanne Grinovero <<a href="mailto:sanne@hibernate.org" target="_blank">sanne@hibernate.org</a>><br>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
I just noticed that the Apache Avro version included in WildFly was<br>
upgraded to 1.8.1.<br>
<br>
This breaks Hibernate Search. It wasn't caught by automated<br>
integration tests as this aspect wasn't covered by integration tests<br>
within the wildfly codebase - we have them within Hibernate.<br>
<br>
A quick grep on the module definitions doesn't reveal any other user,<br>
and "git blame" seems to suggest it was updated just for the sake of<br>
updating some components.. so I'm guessing there is no other<br>
stackeholder I should align with?<br>
<br>
1# Could we please revert it to 1.7.6, which is what Hibernate Search<br>
requires?<br>
<br>
Alternatively we'll need some ad-hoc coding on Hibernate Search and a<br>
new version respin - with all associated risks - just for the sake of<br>
updating this.<br>
<br>
2# What can we do to prevent such things in the future?<br>
<br>
I can of course contribute some more integration tests but it's never<br>
going to be enough: there will always be more tests "upstream". Could<br>
we rather agree on some improved communication process when you all<br>
consider updating an indirect dependency?<br>
<br>
Thanks,<br>
Sanne<br>
<br>
- <a href="https://issues.jboss.org/browse/WFLY-9221" rel="noreferrer" target="_blank">https://issues.jboss.org/brows<wbr>e/WFLY-9221</a><br>
______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/wildfly-dev</a><br>
</blockquote>
<br>
<br>
<br>
--<br>
James R. Perkins<br>
JBoss by Red Hat<br>
</blockquote>
______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/wildfly-dev</a><br>
<br>
<br>
</blockquote>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>James R. Perkins</div><div>JBoss by Red Hat</div></div></div></div></div>
</div>