<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div><blockquote type="cite" class=""><div class="">On Dec 18, 2017, at 4:53 PM, Stuart Douglas <<a href="mailto:stuart.w.douglas@gmail.com" class="">stuart.w.douglas@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Dec 19, 2017 at 3:20 AM, Rostislav Svoboda <span dir="ltr" class=""><<a href="mailto:rsvoboda@redhat.com" target="_blank" class="">rsvoboda@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi.<br class="">
<br class="">
tl;dr: I'm not sure WF is the right place for GRPC integration<br class="">
<br class="">
1) footprint<br class="">
io.grpc: grpc-core grpc-protobuf grpc-stub with deps take 6.1 MB (using version 1.5.0)<br class=""></blockquote><div class=""><br class=""></div><div class="">Not much we can do about that, but it won’t be loaded unless you are using it.</div></div></div></div></div></blockquote><div><br class=""></div>Also once we have provisioning then it could be easily removed and/or kept as an optional feature.<br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
2) speed of development<br class="">
version 1.5.0 in July<br class="">
version 1.8.0 in November<br class="">
speed itself is not the main problem, point 3) is more concerning<br class="">
<br class="">
3) changes in minor releases<br class="">
I tried mvn clean package -Dgrpc.version=1.8.0 on undertow-grpc and got compilation failure with 18 errors<br class=""></blockquote><div class=""><br class=""></div><div class="">Yea, that is somewhat annoying. I don’t think it affects the wire protocol though, just the Java SPI (even though they provide an integration SPI I don't think anyone has really tried to use it before, and provide a transport outside what is already provided in the distribution).</div></div></div></div></div></blockquote><br class=""></div><div>Even with the SPI it looks fairly reasonable: going through the history it appears they deprecate stuff first, then many releases later remove the deprecated methods. Of course I might have missed something.</div><div><br class=""></div><div>-Jason</div><div><br class=""></div><div><br class=""></div></body></html>