<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 22, 2018 at 4:40 AM, Sanne Grinovero <span dir="ltr"><<a href="mailto:sanne@hibernate.org" target="_blank">sanne@hibernate.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">Hi all, Scott,<div dir="auto"><br></div><div dir="auto">the Hibernate ORM and Hibernate Search projects are now producing and releasing feature packs, so please use them rather than re-creating a different set of modules. </div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div dir="auto"><br></div><div dir="auto">We also produced feature packs of several of our dependencies, for example Apache Lucene feature packs have their own repository and versioning: more flexible and consistent with the Lucene version. </div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div dir="auto"><br></div><div dir="auto">We also have chosen different names; e.g. the Hibernate ORM one is called "org.hibernate.orm" and has a slot "5.3".</div></div></blockquote><div><br></div><div>Name sounds fine. </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div dir="auto"><br></div><div dir="auto">Technically that's an alias, the real module has a slot with the full version. </div><div dir="auto"><br></div><div dir="auto">We also included a deprecated module using the older name which imports and exports the new one, to ease transition. </div></div></blockquote><div><br></div><div>What is the deprecated module name/slot? </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div dir="auto"><br></div><div dir="auto">The feature packs for Hibernate Search have been released already, the ones for Hibernate ORM are merged in master but have not been released yet.</div><div dir="auto"><br></div><div dir="auto">Of course we can still make changes to any of them, I'll try the new module descriptors if you prefer them?</div><div dir="auto"><br></div><div dir="auto">Scott: you remember we discussed including a JipiJapa adaptor within the ORM codebase so that a matching version would be released together? This would be a good time, so we include it, want to help me with that? </div></div></blockquote><div><br></div><div>Excellent, yes I want to help with that.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Sanne </div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On 22 Feb 2018 02:06, "Scott Marlow" <<a href="mailto:smarlow@redhat.com" target="_blank">smarlow@redhat.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 21, 2018 at 3:42 PM, David Lloyd <span dir="ltr"><<a href="mailto:david.lloyd@redhat.com" target="_blank">david.lloyd@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I would either keep the slot:<br>
<br>
<module name="org.hibernate" slot="5.3" xmlns="urn:jboss:module:1.5"><br>
<br>
Or use a module 1.7+ descriptor and do it this way:<br>
<br>
<module name="org.hibernate:5.3" xmlns="urn:jboss:module:1.7"><br>
<br>
(still in the org/hibernate/5.3/module.xml path in this case).<br>
<br>
If you don't like using slots, then I'd suggest:<br></blockquote><div><br></div><div>Slots are great, think I will upgrade to the module 1.7+ descriptor and include the slot in the name, as you suggest above.</div><div><br></div><div>Thanks!</div><div>Scott</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<module name="org.hibernate.5_3" xmlns="whatever"><br>
<div><div class="m_-3126255977492997938m_2843100447986955953h5"><br>
<br>
On Wed, Feb 21, 2018 at 2:20 PM, Scott Marlow <<a href="mailto:smarlow@redhat.com" target="_blank">smarlow@redhat.com</a>> wrote:<br>
> Any suggestions for what we should call the new Hibernate ORM 5.3 module?<br>
> We can probably drop the slot and just include the version in the module<br>
> name.<br>
><br>
> Some ideas:<br>
><br>
> name="org.hibernate5.3"<br>
> name="org.hibernate5_3"<br>
> name="org.hibernate5-3"<br>
><br>
> Any suggestions?<br>
><br>
> Scott<br>
><br>
</div></div><span>> ______________________________<wbr>_________________<br>
> wildfly-dev mailing list<br>
> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/wildfly-dev</a><br>
<br>
<br>
<br>
--<br>
</span>- DML<br>
</blockquote></div><br></div></div>
<br>______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/wildfly-dev</a><br></blockquote></div></div>
</div></div></blockquote></div><br></div></div>