<div dir="ltr"><div>Hey Rebecca,</div><div><br></div><div>I've initially wrote that script but to be fair I do not really remember reasoning behind every detail...</div><div><br></div><div>But one thing I do remember is that enviroment variables have different scopes.</div><div>and should not be equaled to how env variables in powershell work comparing to linux.</div><div><br></div><div>So you have scopes which can be <br></div><div>- system enviroment, (which can differ as per user/per whole system)<br></div><div>- script local (bit special with imports/includes)</div><div>- process local</div><div><br></div><div>and I do remember I did play around with process scope a bit to get some stuff working.</div><div><br></div><div>Main goal was to have common.ps1 that would have common logic for all scripts.</div><div>and than the actual scripts (standalone.ps1, jboss-cli.ps1,...) would just have the extra specifics.</div><div><br></div><div>One thing I was also looking into was creating common.ps1 as a powershell module [1] [2],</div><div>that would server as that "common" part and it would simplify things even more.</div><div>But I never got to finishing it.<br></div><div><br></div><div>I know this is all really vague, but I still hope it will help a bit.</div><div><br></div><div>cheers,</div><div>tomaz<br></div><div><br></div><div>[1] <a href="https://msdn.microsoft.com/en-us/library/dd878340(v=vs.85).aspx">https://msdn.microsoft.com/en-us/library/dd878340(v=vs.85).aspx</a></div><div>[2] <a href="https://msdn.microsoft.com/en-us/library/dd878324(v=vs.85).aspx">https://msdn.microsoft.com/en-us/library/dd878324(v=vs.85).aspx</a><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 23, 2018 at 8:53 PM, Rebecca Searls <span dir="ltr"><<a href="mailto:rsearls@redhat.com" target="_blank">rsearls@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-size:small"><br>I don't understand the reason for setting the (local) variable JAVA_OPTS<br>in the *.conf.ps1 files when the common.ps1 functions completely ignores<br>the local setting and always reads and uses the environment variable value.<br><br>The in-file comments leads the reader to believe he can override the system<br>env var and define a new JAVA_OPTS in the conf file which will be used by the <br>calling script. Currently this is not true.<br><br>Can someone explain the intent here? Is this a bug or obsolete code that<br>should be removed?<br><br></div></div>
<br>______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/wildfly-dev</a><br></blockquote></div><br></div>