<div dir="ltr">Hey Tom!<div><br></div><div>Could you please tell me what is the status of this? It seems one of the Keycloak users got hit by this problem: <a href="http://lists.jboss.org/pipermail/keycloak-dev/2018-July/010985.html">http://lists.jboss.org/pipermail/keycloak-dev/2018-July/010985.html</a></div><div><br></div><div>Thanks,</div><div>Sebastian</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, May 10, 2018 at 11:10 AM Tom Jenkinson &lt;<a href="mailto:tom.jenkinson@redhat.com">tom.jenkinson@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sure - thanks!</div><div class="gmail_extra"><br><div class="gmail_quote">On 10 May 2018 at 02:56, Sebastian Laskawiec <span dir="ltr">&lt;<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I&#39;m sorry for delay... I got sucked by the Summit prep activities.<div><br></div><div>Yes, to all, what you said! Shall I create a JIRA for you?</div><div><div class="m_-6217249641163389308h5"><div><div><br></div><div><br></div><br><div class="gmail_quote"><div dir="ltr">On Wed, May 9, 2018 at 9:39 AM Tom Jenkinson &lt;<a href="mailto:tom.jenkinson@redhat.com" target="_blank">tom.jenkinson@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks Brian. Does it work for you Sebastian?</div><div class="gmail_extra"><br><div class="gmail_quote">On 8 May 2018 at 23:05, Brian Stansberry <span dir="ltr">&lt;<a href="mailto:brian.stansberry@redhat.com" target="_blank">brian.stansberry@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ah, ok. I was thinking of scripting in the broad sense the various stuff that goes into creating images.<div><br></div><div>In any case, I don&#39;t see any downside to having <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">node-identifier=&quot;${</span><a href="http://jboss.tx.node.id:1/" style="color:rgb(17,85,204);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)" target="_blank">jboss.tx.node.id:1</a><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">}&quot; in the standard WF config files.</span><br><div><br></div><div><br></div></div></div><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295HOEnZb"><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 8, 2018 at 3:07 PM, Tom Jenkinson <span dir="ltr">&lt;<a href="mailto:tom.jenkinson@redhat.com" target="_blank">tom.jenkinson@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I think they want to avoid changing the standalone.xml file and just want to control it from their startup script.</div><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454HOEnZb"><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454h5"><div class="gmail_extra"><br><div class="gmail_quote">On 8 May 2018 at 18:45, Brian Stansberry <span dir="ltr">&lt;<a href="mailto:brian.stansberry@redhat.com" target="_blank">brian.stansberry@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I might have missed something along the way, but if they are going to do scripting wouldn&#39;t they just set the attribute to ${<a href="http://jboss.node.name" target="_blank">jboss.node.name</a>} and count on the fact that this is unique per pod?</div><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165HOEnZb"><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 8, 2018 at 3:28 AM, Tom Jenkinson <span dir="ltr">&lt;<a href="mailto:tom.jenkinson@redhat.com" target="_blank">tom.jenkinson@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks for confirming Brian.<div><br></div><div>Perhaps we could set it to:</div><div>node-identifier=&quot;${<a href="http://jboss.tx.node.id:1" target="_blank">jboss.tx.node.id:1</a>}&quot;<br></div><div>(a bit like <a href="https://github.com/jboss-developer/jboss-eap-quickstarts/tree/7.1/jts" target="_blank">https://github.com/jboss-developer/jboss-eap-quickstarts/tree/7.1/jts</a>)</div><div><br>Sebastian could set -<a href="http://Djboss.tx.node.id" target="_blank">Djboss.tx.node.id</a> during startup in a script?</div><div><br></div><div><br></div></div><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650HOEnZb"><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650h5"><div class="gmail_extra"><br><div class="gmail_quote">On 7 May 2018 at 22:08, Brian Stansberry <span dir="ltr">&lt;<a href="mailto:brian.stansberry@redhat.com" target="_blank">brian.stansberry@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">If it&#39;s not already set, </span>WildFly sets the system property <a href="http://jboss.node.name" target="_blank">jboss.node.name</a> at the very beginning of server boot, so <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">${</span><a href="http://jboss.node.name/" style="color:rgb(17,85,204);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)" target="_blank">jboss.node.name</a><b style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">:1</b><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">} would not resolve to 1.</span> <br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995h5">On Sun, May 6, 2018 at 6:10 PM, Sebastian Laskawiec <span dir="ltr">&lt;<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a>&gt;</span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995h5"><div dir="ltr">Ok, so how about doing the same thing you suggested, but just more explicitly - adding node-identifier=&quot;${<a href="http://jboss.node.name" target="_blank">jboss.node.name</a><b>:1</b>}&quot;. This way the bare metal deployment should be happy (since the default is still 1) and we wouldn&#39;t need to override it in Infinispan. </div><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995m_1447996983425202585HOEnZb"><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995m_1447996983425202585h5"><br><div class="gmail_quote"><div dir="ltr">On Tue, May 1, 2018 at 10:09 AM Tom Jenkinson &lt;<a href="mailto:tom.jenkinson@redhat.com" target="_blank">tom.jenkinson@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I am not sure - the default should be &quot;1&quot; for the bare metal case so the warning is reliably triggered but the default can be the pod name for OpenShift templates that only allow a single instance of the application server - does that help? <div><br></div><div>The file you looked to want to edit is shared by bare metal and other deployment environments so it would be confusing to set the default to <a href="http://jboss.node.name" target="_blank">jboss.node.name</a> there IMO.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 1 May 2018 at 03:39, Sebastian Laskawiec <span dir="ltr">&lt;<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Fair enough Tom. Thanks for explanation.<div><br></div><div>One more request - would you guys be OK with me adding a node-identifier=&quot;${<a href="http://jboss.node.name" target="_blank">jboss.node.name</a>}&quot; to the transaction subsystem template [1]? This way we wouldn&#39;t need to copy it into Infinispan (since we need to set it).</div><div><br></div><div>[1] <a href="https://github.com/wildfly/wildfly/blob/master/transactions/src/main/resources/subsystem-templates/transactions.xml#L6" target="_blank">https://github.com/wildfly/wildfly/blob/master/transactions/src/main/resources/subsystem-templates/transactions.xml#L6</a></div></div><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995m_1447996983425202585m_239099127790923549m_-1705377625340620592HOEnZb"><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995m_1447996983425202585m_239099127790923549m_-1705377625340620592h5"><br><div class="gmail_quote"><div dir="ltr">On Wed, Apr 18, 2018 at 3:37 PM Tom Jenkinson &lt;<a href="mailto:tom.jenkinson@redhat.com" target="_blank">tom.jenkinson@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 18 April 2018 at 14:07, Sebastian Laskawiec <span dir="ltr">&lt;<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hey Tom,<div><br></div><div>Comments inlined.</div><div><br></div><div>Thanks,</div><div>Sebastian<br><br><div class="gmail_quote"><div><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995m_1447996983425202585m_239099127790923549m_-1705377625340620592m_5802046673480658021m_2261263716859832444h5"><div dir="ltr">On Tue, Apr 17, 2018 at 4:37 PM Tom Jenkinson &lt;<a href="mailto:tom.jenkinson@redhat.com" target="_blank">tom.jenkinson@redhat.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 16 April 2018 at 09:31,  <span dir="ltr">&lt;<a></a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Adding +WildFly Dev &lt;wildfly-dev at <a href="http://lists.jboss.org" rel="noreferrer" target="_blank">lists.jboss.org</a>&gt; to the loop</blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
Thanks for the explanation Rado.<br>
<br>
TL;DR: A while ago Sanne pointed out that we do not set `node-identifier`<br>
in transaction subsystem by default. The default value for the<br>
`node-identifier` attribute it `1`. Not setting this attribute might cause<br>
problems in transaction recovery. Perhaps we could follow Rado&#39;s idea and<br>
set it to node name by default?<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>

<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Indeed - it would cause serious data integrity problems if a non-unique node-identifier is used.</span>

 </div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Some more comments inlined.<br>
<br>
Thanks,<br>
Sebastian<br>
<br>
On Fri, Apr 13, 2018 at 7:07 PM Radoslav Husar &lt;rhusar at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a>&gt; wrote:<br>
<br>
&gt; Hi Sebastian,<br>
&gt;<br>
&gt; On Wed, Apr 11, 2018 at 2:31 PM, Sebastian Laskawiec<br>
&gt; &lt;slaskawi at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a>&gt; wrote:<br>
&gt; &gt; Hey Rado, Paul,<br>
&gt; &gt;<br>
&gt; &gt; I started looking into this issue and it turned out that WF subsystem<br>
&gt; &gt; template doesn&#39;t provide `node-identifier` attribute [1].<br>
&gt;<br>
&gt; I assume you mean that the default WildFly server profiles do not<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt; explicitly define the attribute. Right ? thus the value defaults in</blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
&gt; the model to &quot;1&quot;<br>
&gt;<br>
&gt; <a href="https://github.com/wildfly/wildfly/blob/master/transactions/src/main/java/org/jboss/as/txn/subsystem/TransactionSubsystemRootResourceDefinition.java#L97" rel="noreferrer" target="_blank">https://github.com/wildfly/wildfly/blob/master/transactions/src/main/java/org/jboss/as/txn/subsystem/TransactionSubsystemRootResourceDefinition.java#L97</a><br>
&gt; which sole intention seems to be to log a warning on boot if the value<br>
&gt; is unchanged.<br>
&gt; Why they decided on a constant that will be inherently not unique as<br>
&gt; opposed to defaulting to the node name (which we already require to be<br>
&gt; unique) as clustering node name or undertow instance-id does, is<br>
&gt; unclear to me.<br>
&gt; Some context is on <a href="https://issues.jboss.org/browse/WFLY-1119" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/WFLY-1119</a>.<br>
&gt;<br>
<br>
In OpenShift environment we could set it to `hostname`. This is guaranteed<br>
to be unique in whole OpenShift cluster.<br>
<br>
<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>
We do this too in EAP images.
<br>To Rado&#39;s point, the default is &quot;1&quot; so we can print the warning to alert 
people they are misconfigured - it seems to be working :)<br></div></div></div></div></blockquote><div><br></div></div></div><div>This is the point. From my understanding, if we set it to node name (instead of &quot;1&quot;), we could make it always work correctly. We could even remove the code that emits the warning (since the node name needs to be unique).</div><div><br></div><div>To sum it up - if we decided to proceed this way, there would be no requirement of setting the node-identifier at all.</div></div></div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>For OpenShift you are right there is no requirement for someone to change the node-identifier from the podname and so that is why EAP images do that. </div><div><br></div><div>For bare-metal it is different as there can be two servers on the same machine so they were configured to use the hostname as they node-identifier then if they were also connected to the same resource managers or the same object store they would interfere with each other.</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="gmail_quote"><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div> </div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt;</blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
&gt; &gt; I&#39;m not sure if you guys are the right people to ask, but is it safe to<br>
&gt; &gt; leave it set to default? Or shall I override our Infinispan templates and<br>
&gt; &gt; add this parameter (as I mentioned before, in OpenShift this I wanted to<br>
&gt; set<br>
&gt; &gt; it as Pod name trimmed to the last 23 chars since this is the limit).<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>
Putting a response to this in line - I am not certain who originally 
proposed this.
<br>
<br>You must use a globally unique node-identifier. If you are certain the 
last 23 characters guarantee that it would be valid - if there is a 
chance they are not unique it is not valid to trim.
<br></div></div></div></div></blockquote><div><br></div></span><div>If that&#39;s not an issue, again, we could use the same limit as we have for node name.</div><div><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995m_1447996983425202585m_239099127790923549m_-1705377625340620592m_5802046673480658021m_2261263716859832444h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>


<br></div><div> </div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt;</blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
&gt; It is not safe to leave it set to &quot;1&quot; as that results in inconsistent<br>
&gt; processing of transaction recovery.<br>
&gt; IIUC we already set it to the node name for both EAP and JDG<br>
&gt;<br>
&gt; <a href="https://github.com/jboss-openshift/cct_module/blob/master/os-eap70-openshift/added/standalone-openshift.xml#L411" rel="noreferrer" target="_blank">https://github.com/jboss-openshift/cct_module/blob/master/os-eap70-openshift/added/standalone-openshift.xml#L411</a><br>
&gt;<br>
&gt; <a href="https://github.com/jboss-openshift/cct_module/blob/master/os-jdg7-conffiles/added/clustered-openshift.xml#L282" rel="noreferrer" target="_blank">https://github.com/jboss-openshift/cct_module/blob/master/os-jdg7-conffiles/added/clustered-openshift.xml#L282</a><br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt; which in turn defaults to the pod name ? so which profiles are we</blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
&gt; talking about here?<br>
&gt;<br>
<br>
Granted, we set it by default in CCT Modules. However in Infinispan we just<br>
grab provided transaction subsystem when rendering full configuration from<br>
featurepacks:<br>
<a href="https://github.com/infinispan/infinispan/blob/master/server/integration/feature-pack/src/main/resources/configuration/standalone/subsystems-cloud.xml#L19" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/blob/master/server/integration/feature-pack/src/main/resources/configuration/standalone/subsystems-cloud.xml#L19</a><br>
<br>
The default configuration XML doesn&#39;t contain the `node-identifier`<br>
attribute. I can add it manually in the cloud.xml but I believe the right<br>
approach is to modify the transaction subsystem.<br>
<br>
<br>
&gt; Rado<br>
&gt;<br>
&gt; &gt; Thanks,<br>
&gt; &gt; Seb<br>
&gt; &gt;<br>
&gt; &gt; [1] usually set to node-identifier=&quot;${<a href="http://jboss.node.name" rel="noreferrer" target="_blank">jboss.node.name</a>}&quot;<br>
&gt; &gt;<br>
&gt; &gt;<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt; &gt; On Mon, Apr 9, 2018 at 10:39 AM Sanne Grinovero &lt;sanne at <a href="http://infinispan.org" rel="noreferrer" target="_blank">infinispan.org</a>&gt;<br>
&gt; &gt; wrote:<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; On 9 April 2018 at 09:26, Sebastian Laskawiec &lt;slaskawi at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a>&gt;</blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
&gt; wrote:<br>
&gt; &gt;&gt; &gt; Thanks for looking into it Sanne. Of course, we should add it (it can<br>
&gt; be<br>
&gt; &gt;&gt; &gt; set<br>
&gt; &gt;&gt; &gt; to the same name as hostname since those are unique in Kubernetes).<br>
&gt; &gt;&gt; &gt;<br>
&gt; &gt;&gt; &gt; Created <a href="https://issues.jboss.org/browse/ISPN-9051" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/ISPN-9051</a> for it.<br>
&gt; &gt;&gt; &gt;<br>
&gt; &gt;&gt; &gt; Thanks again!<br>
&gt; &gt;&gt; &gt; Seb<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; Thanks Sebastian!<br>
&gt; &gt;&gt;<br>
&gt; &gt;&gt; &gt;<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt; &gt;&gt; &gt; On Fri, Apr 6, 2018 at 8:53 PM Sanne Grinovero &lt;sanne at <a href="http://infinispan.org" rel="noreferrer" target="_blank">infinispan.org</a>&gt;</blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
&gt; &gt;&gt; &gt; wrote:<br>
&gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt;&gt; &gt;&gt; Hi all,<br>
&gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt;&gt; &gt;&gt; I&#39;ve started to use the Infinispan Openshift Template and was<br>
&gt; browsing<br>
&gt; &gt;&gt; &gt;&gt; through the errors and warnings this produces.<br>
&gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt;&gt; &gt;&gt; In particular I noticed &quot;WFLYTX0013: Node identifier property is set<br>
&gt; &gt;&gt; &gt;&gt; to the default value. Please make sure it is unique.&quot; being produced<br>
&gt; &gt;&gt; &gt;&gt; by the transaction system.<br>
&gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt;&gt; &gt;&gt; The node id is usually not needed for developer&#39;s convenience and<br>
&gt; &gt;&gt; &gt;&gt; assuming there&#39;s a single node in &quot;dev mode&quot;, yet clearly the<br>
&gt; &gt;&gt; &gt;&gt; Infinispan template is meant to work with multiple nodes running so<br>
&gt; &gt;&gt; &gt;&gt; this warning seems concerning.<br>
&gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt;&gt; &gt;&gt; I&#39;m not sure what the impact is on the transaction manager so I asked<br>
&gt; &gt;&gt; &gt;&gt; on the Narayana forums; Tom pointed me to some thourough design<br>
&gt; &gt;&gt; &gt;&gt; documents and also suggested the EAP image does set the node<br>
&gt; &gt;&gt; &gt;&gt; identifier:<br>
&gt; &gt;&gt; &gt;&gt;  - <a href="https://developer.jboss.org/message/981702#981702" rel="noreferrer" target="_blank">https://developer.jboss.org/message/981702#981702</a><br>
&gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt;&gt; &gt;&gt; WDYT? we probably want the Infinispan template to set this as well,<br>
&gt; or<br>
&gt; &gt;&gt; &gt;&gt; silence the warning?<br>
&gt; &gt;&gt; &gt;&gt;<br>
&gt; &gt;&gt; &gt;&gt; Thanks,<br>
&gt; &gt;&gt; &gt;&gt; Sanne<br>
&gt; &gt;&gt; &gt;&gt; _______________________________________________<br>
&gt; &gt;&gt; &gt;&gt; infinispan-dev mailing list<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt; &gt;&gt; &gt;&gt; infinispan-dev at <a href="http://lists.jboss.org" rel="noreferrer" target="_blank">lists.jboss.org</a></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
&gt; &gt;&gt; &gt;&gt; <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
&gt; &gt;&gt; &gt;<br>
&gt; &gt;&gt; &gt;<br>
&gt; &gt;&gt; &gt; _______________________________________________<br>
&gt; &gt;&gt; &gt; infinispan-dev mailing list<br></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt; &gt;&gt; &gt; infinispan-dev at <a href="http://lists.jboss.org" rel="noreferrer" target="_blank">lists.jboss.org</a></blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
&gt; &gt;&gt; &gt; <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
&gt; &gt;&gt; _______________________________________________<br>
&gt; &gt;&gt; infinispan-dev mailing list<br>
&gt; &gt;&gt; infinispan-dev at <a href="http://lists.jboss.org" rel="noreferrer" target="_blank">lists.jboss.org</a><br>
&gt; &gt;&gt; <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
&gt;<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <a href="http://lists.jboss.org/pipermail/wildfly-dev/attachments/20180416/65962cf1/attachment-0001.html" rel="noreferrer" target="_blank">http://lists.jboss.org/pipermail/wildfly-dev/attachments/20180416/65962cf1/attachment-0001.html</a> <br>
<br>
<br>
<br>
</blockquote></div></div></div></blockquote></div></div></div></div></div>
</blockquote></div></div></div></blockquote></div>
</div></div></blockquote></div><br></div>
</blockquote></div>
</div></div><br></div></div>_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><span class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995HOEnZb"><font color="#888888"><br></font></span></blockquote></div><span class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650m_-2104812387053468995m_1447996983425202585gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div>
</font></span></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454m_5569645650865146165m_-2371203937636306650gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div>
</div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_-6217249641163389308m_-4517060106258640701m_8980886134533895295m_7306869923222674454gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div>
</div>
</div></div></blockquote></div><br></div>
</blockquote></div></div></div></div></div>
</blockquote></div><br></div>
</blockquote></div>