<div dir="ltr">So basically the issue here is that the xml attribute should be called 'name' instead of 'pool-name'?<div><br></div><div>Sounds like a minor Enhancement not a major Bug. If there's much in the way of docs out there that use pool-name then the cost of changing it (wrong docs) may outweigh any benefit.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 19, 2018 at 9:24 AM, Tomas Hofman <span dir="ltr"><<a href="mailto:thofman@redhat.com" target="_blank">thofman@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The <admin-object> and <connection-definition> elements in resource adapters <br>
subsystem have "pool-name" attribute that looks like it isn't used for <br>
anything, which is misleading for users.<br>
<br>
It looks that "pool-name" attribute was intended for functionality that wasn't <br>
implemented. The attributes are only present in XML, and do not exist in <br>
management model.<br>
<br>
During resource creation the values are passed into service value objects <br>
(ModifiableAdminObject, ModifiableConnDef), but #getPoolName() methods are not <br>
called from anywhere.<br>
<br>
The attributes can't be simply removed because their values are used for <br>
resource addressing, e.g.<br>
<br>
/subsystem=resource-adapters/.<wbr>../admin-objects=test-a-o:add(<wbr>...)<br>
<br>
will produce<br>
<br>
<admin-object ... pool-name="test-a-o"/><br>
<br>
so some "name" attribute is still needed.<br>
<br>
Unless you think that this is not worth having new schema version (or the <br>
intended functionality that requires "pool-name" attrs is planned to be <br>
implemented), I would create new XSD schema version with "pool-name" renamed to <br>
"name" and update the parser. I suppose the new XSD version should be 6.0, <br>
rather than 5.1, no matter how small the change.<br>
<br>
Also, AFAIK this change couldn't be backported to released product streams.<br>
<br>
The issue where this was raised is <a href="https://issues.jboss.org/browse/JBEAP-15023" rel="noreferrer" target="_blank">https://issues.jboss.org/<wbr>browse/JBEAP-15023</a><br>
<span class="HOEnZb"><font color="#888888"><br>
-- <br>
Tomas Hofman<br>
Software Engineer, JBoss SET<br>
Red Hat<br>
______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/wildfly-dev</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div>
</div>