<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 30, 2018 at 3:32 AM, Tomas Hofman <span dir="ltr"><<a href="mailto:thofman@redhat.com" target="_blank">thofman@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yes, that's what I believe should be done.<br>
<br>
Adding also Tomasz and Tom :).<br>
<br>
I'm yet to asses the impact on documentation, by my feeling from my initial investigation was that I didn't found very many documents dealing with this.<br></blockquote><div><br></div><div>Please check with the Teiid folks, as Teiid heavily uses this subsystem.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Am I correct in thinking that if the new parser is able to parse the old config version, no other migration work is needed?<br></blockquote><div><br></div><div>Right, unless Stefano wants the parser for the new schema version to be forgiving and allow the old attribute.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Tomas<span class=""><br>
<br>
On 19/07/18 22:38, Brian Stansberry wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
So basically the issue here is that the xml attribute should be called 'name' instead of 'pool-name'?<br>
<br>
Sounds like a minor Enhancement not a major Bug. If there's much in the way of docs out there that use pool-name then the cost of changing it (wrong docs) may outweigh any benefit.<br>
<br></span><div><div class="h5">
On Thu, Jul 19, 2018 at 9:24 AM, Tomas Hofman <<a href="mailto:thofman@redhat.com" target="_blank">thofman@redhat.com</a> <mailto:<a href="mailto:thofman@redhat.com" target="_blank">thofman@redhat.com</a>>> wrote:<br>
<br>
The <admin-object> and <connection-definition> elements in resource adapters<br>
subsystem have "pool-name" attribute that looks like it isn't used for<br>
anything, which is misleading for users.<br>
<br>
It looks that "pool-name" attribute was intended for functionality that wasn't<br>
implemented. The attributes are only present in XML, and do not exist in<br>
management model.<br>
<br>
During resource creation the values are passed into service value objects<br>
(ModifiableAdminObject, ModifiableConnDef), but #getPoolName() methods are not<br>
called from anywhere.<br>
<br>
The attributes can't be simply removed because their values are used for<br>
resource addressing, e.g.<br>
<br>
/subsystem=resource-adapters/<wbr>.../admin-objects=test-a-o:add<wbr>(...)<br>
<br>
will produce<br>
<br>
<admin-object ... pool-name="test-a-o"/><br>
<br>
so some "name" attribute is still needed.<br>
<br>
Unless you think that this is not worth having new schema version (or the<br>
intended functionality that requires "pool-name" attrs is planned to be<br>
implemented), I would create new XSD schema version with "pool-name"<br>
renamed to<br>
"name" and update the parser. I suppose the new XSD version should be 6.0,<br>
rather than 5.1, no matter how small the change.<br>
<br>
Also, AFAIK this change couldn't be backported to released product streams.<br>
<br>
The issue where this was raised is<br>
<a href="https://issues.jboss.org/browse/JBEAP-15023" rel="noreferrer" target="_blank">https://issues.jboss.org/brows<wbr>e/JBEAP-15023</a><br>
<<a href="https://issues.jboss.org/browse/JBEAP-15023" rel="noreferrer" target="_blank">https://issues.jboss.org/brow<wbr>se/JBEAP-15023</a>><br>
<br>
-- Tomas Hofman<br>
Software Engineer, JBoss SET<br>
Red Hat<br>
______________________________<wbr>_________________<br>
wildfly-dev mailing list<br></div></div>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a> <mailto:<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jbos<wbr>s.org</a>><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/wildfly-dev</a><span class=""><br>
<<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailm<wbr>an/listinfo/wildfly-dev</a>><br>
<br>
<br>
<br>
<br>
-- <br>
Brian Stansberry<br>
Manager, Senior Principal Software Engineer<br>
Red Hat<br>
</span></blockquote>
<br><div class="HOEnZb"><div class="h5">
-- <br>
Tomas Hofman<br>
Software Engineer, JBoss SET<br>
Red Hat<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div>
</div></div>