<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Nov 12, 2018 at 3:54 AM Jean-Francois Denise <<a href="mailto:jdenise@redhat.com">jdenise@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Thank-you.<br>
</p>
<br>
<div class="m_8658733055445412617moz-cite-prefix">On 09/11/2018 19:45, James Perkins
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div>The main reason those modules are dependencies of the
logging subsystem is because they are not really required
for the subsystem itself with the exception of
org.jboss.logging. Those module dependencies are added to
deployments for convenience. So really they're not required
at all unless the user is using one of those logging
frameworks and they want the logging subsystem to control
the logging output.<br>
</div>
</div>
</div>
</blockquote>
There is some logic to attempt to load the module, if it succeeds,
then the dependency is added as a required one. Could this be
replaced by an optional dependency and no module loading? These
modules would have to to be added thanks to
addAdditionalOptionalPackages. <br></div></blockquote><div><br></div><div>I guess it really does make sense to have them as optional dependencies in the module.xml. Using the addAddtionalOptionalPackages would work too though. I'd be good with doing it either way so which ever makes the most sense for Galleon. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div><br>
</div>
<div>This may be somewhat of an edge case because if the user
doesn't use, say slf4j, then there is no real reason to
include the dependency unless of course another module uses
it. I do wonder if we should remove the
org.jboss.logging.jul-to-slf4j-stub module and just put the
library as a resource root to org.slf4j, but that's slightly
OT :)</div><div class="gmail_quote">
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="m_8658733055445412617gmail-m_2190110884848930393gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>James R. Perkins</div>
<div>JBoss by Red Hat</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="m_8658733055445412617mimeAttachmentHeader"></fieldset>
<br>
<pre>_______________________________________________
wildfly-dev mailing list
<a class="m_8658733055445412617moz-txt-link-abbreviated" href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a>
<a class="m_8658733055445412617moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></pre>
</blockquote>
<br>
</div>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>James R. Perkins</div><div>JBoss by Red Hat</div></div></div></div></div></div>