<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 4, 2019 at 4:58 AM Carlo de Wolf <<a href="mailto:cdewolf@redhat.com">cdewolf@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
Define the end-state.<br>
<br>
If commons-lang3 is part of that end-state it makes no sense to
remove it from the matrix. Were it not for CXF it could however be
removed from the runtime.<br>
<br>
Don't drive into a road which could potentially be a dead-end.<br></div></blockquote><div><br></div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif">I'm not aiming in this thread at removing things we use. My only aim was to remove cruft. I missed the use of org.apache.commons.lang3. (Thansk, Jim!) It's used so I won't be removing it.</div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif"><br></div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif">Same for commons.cli.</div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif"><br></div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif">So this is really just about org.apache.commons.lang</div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
<br>
Carlo<br>
<br>
<div class="gmail-m_-6259170811902728001moz-cite-prefix">On 03-04-19 16:51, Darran Lofthouse
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Certainly a topic for the future.</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Wed, Apr 3, 2019 at 3:36 PM
Fernando Nasser <<a href="mailto:fnasser@redhat.com" target="_blank">fnasser@redhat.com</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<div class="gmail-m_-6259170811902728001gmail-m_2684602645108186651moz-cite-prefix">On
2019-04-03 4:43 a.m., Darran Lofthouse wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">+1 the tool is a shaded jar so should not
need to depend on another module.<br>
<div><br>
</div>
<div>We may want to look at shading again but that would
be a different topic.</div>
</div>
</blockquote>
<p><br>
</p>
<p>Indeed. <br>
</p>
<p>Who monitors/detects the shaded code does not contain a
CVE and fix it if it does? <br>
</p>
<p>Are the people who "shaded" it responsible for
supporting/maintaining that code?</p>
<p><br>
</p>
<blockquote type="cite"><br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Apr 2, 2019 at
10:13 PM James Perkins <<a href="mailto:jperkins@redhat.com" target="_blank">jperkins@redhat.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">I believe the
org.wildfly.security:wildfly-elytron-tool does use
org.apache.commons.lang3. However IIRC it's now
shaded in so likely not an issue. That could be why
it was originally there.<br class="gmail-m_-6259170811902728001gmail-m_2684602645108186651gmail-m_-6902368537796706729gmail-Apple-interchange-newline">
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Apr 2,
2019 at 12:34 PM Brian Stansberry <<a href="mailto:brian.stansberry@redhat.com" target="_blank">brian.stansberry@redhat.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>Currently WildFly
includes 3 JBoss Modules modules that are not
used in our runtime. I would like to remove
these in WildFly 17:</div>
<div><br>
</div>
org.apache.commons.cli<br>
org.apache.commons.lang<span class="gmail_default">[1]</span><br>
org.apache.commons.lang3
<div><br>
</div>
<div>
<div>All three have the
"jboss.api" = "private" property set in
their module.xml, meaning they are marked
for internal use only and we are free to
remove them. End user applications should
not have referenced these modules, and if
they do we log a WARN on boot advising not
to do that.</div>
<div><br>
</div>
<div>However, other
projects that extend WildFly (i.e. write
their own subsystems) may be using these
modules, so I wanted to notify any such
folks that these will likely be going away
and you'll need to provide these
yourselves.ed.</div>
</div>
<div><br>
</div>
<div>Best regards,</div>
<div>Brian</div>
<div><br>
</div>
<div>
<div>[1] This one is
referenced in a commented out module.xml
section related to My Faces 1.1 support.
I've checked with Farah Juma and that is no
longer relevant and the comment can be
removed.</div>
</div>
<br>
</div>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail-m_-6259170811902728001gmail-m_2684602645108186651gmail-m_-6902368537796706729gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>James R. Perkins</div>
<div>JBoss by Red Hat</div>
</div>
</div>
</div>
</div>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></blockquote>
</div>
<br>
<fieldset class="gmail-m_-6259170811902728001gmail-m_2684602645108186651mimeAttachmentHeader"></fieldset>
<pre class="gmail-m_-6259170811902728001gmail-m_2684602645108186651moz-quote-pre">_______________________________________________
wildfly-dev mailing list
<a class="gmail-m_-6259170811902728001gmail-m_2684602645108186651moz-txt-link-abbreviated" href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a>
<a class="gmail-m_-6259170811902728001gmail-m_2684602645108186651moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></pre>
</blockquote>
<p><br>
</p>
</div>
</blockquote>
</div>
<br>
<fieldset class="gmail-m_-6259170811902728001mimeAttachmentHeader"></fieldset>
<pre class="gmail-m_-6259170811902728001moz-quote-pre">_______________________________________________
wildfly-dev mailing list
<a class="gmail-m_-6259170811902728001moz-txt-link-abbreviated" href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a>
<a class="gmail-m_-6259170811902728001moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></pre>
</blockquote>
<br>
</div>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div></div>