<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Wolfgang: yours and mine PRs are merged, and when WFLY 17 Final is out I will also deploy the archetype, thanks a lot for your contribution! Yet now I have to ask, do you plan to submit similar for the other old javaee archetype? :-)<div class=""><br class=""></div><div class="">Brian: yep it was just the JDK, I will deploy these too (no planned updates in such code tho)</div><div class=""><br class=""></div><div class="">—E<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 16 May 2019, at 10:09, Eduardo Martins <<a href="mailto:emartins@redhat.com" class="">emartins@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hmm ok, maybe it just failed build due to some specific like JDK 11, will recheck that.<div class=""><br class=""></div><div class="">—E<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On 16 May 2019, at 02:25, Brian Stansberry <<a href="mailto:brian.stansberry@redhat.com" class="">brian.stansberry@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">These build for me.</div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><br class=""></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">They're not as out of date as I'd thought either.</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 10, 2019 at 6:34 PM Eduardo Martins <<a href="mailto:emartins@redhat.com" class="">emartins@redhat.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class=""><div dir="auto" class="">If you think it’s not a small effort task then certainly agree that’s not a blocker, I look at the archetypes same way as the quickstarts, an aggregation project, so we may take outdated/faulty ones out of build and release the working+actual ones. We may give it a thought later if it makes sense effort wise to update or drop the subsystem ones, no worries.</div></div><div dir="auto" class=""><br class=""></div><div class=""><div dir="auto" class="">—E</div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 10 May 2019 at 21:46, Brian Stansberry <<a href="mailto:brian.stansberry@redhat.com" target="_blank" class="">brian.stansberry@redhat.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class=""><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif">Is that blocking this Eduardo?</div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif"><br class=""></div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif">If not, updating those is a pretty big task and right now I don't see it happening anytime soon.</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 10, 2019 at 3:10 PM Eduardo Martins <<a href="mailto:emartins@redhat.com" target="_blank" class="">emartins@redhat.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Brian, any idea what to do wrt the subsystem archetypes? ATM even build fails and most likely there is someone else better than me to look into that…<br class="">
<br class="">
—E<br class="">
<br class="">
> On 7 May 2019, at 09:18, Eduardo Martins <<a href="mailto:emartins@redhat.com" target="_blank" class="">emartins@redhat.com</a>> wrote:<br class="">
> <br class="">
> Hi Wolfgang, I actually did start reviewing it, but unfortunately had to put it on hold due to unexpected blocker kind of priority tasks/issues needed to be solved asap. If nothing urgent comes I should be able to finish the review the next couple of days.<br class="">
> <br class="">
> —E<br class="">
> <br class="">
>> On 6 May 2019, at 20:50, Wolfgang Knauf <<a href="mailto:wolfgang.knauf@gmx.de" target="_blank" class="">wolfgang.knauf@gmx.de</a>> wrote:<br class="">
>> <br class="">
>> Hi,<br class="">
>> <br class="">
>> just want to ask for an update ;-)<br class="">
>> <br class="">
>> Best regards<br class="">
>> <br class="">
>> Wolfgang<br class="">
>> <br class="">
>> Am 31.03.19 um 21:34 schrieb Eduardo Martins:<br class="">
>>> I will review it, soon hopefully.<br class="">
>>> <br class="">
>>> —E<br class="">
>>> <br class="">
>>>> On 31 Mar 2019, at 19:40, Wolfgang Knauf <<a href="mailto:wolfgang.knauf@gmx.de" target="_blank" class="">wolfgang.knauf@gmx.de</a>> wrote:<br class="">
>>>> <br class="">
>>>> Hi,<br class="">
>>>> <br class="">
>>>> just want to ask about the state of the pull request and further steps...<br class="">
>>>> <br class="">
>>>> Best regards<br class="">
>>>> <br class="">
>>>> Wolfgang<br class="">
>>>> <br class="">
>>>> Am 21.03.19 um 12:47 schrieb Wolfgang Knauf:<br class="">
>>>>> OK, I sent a pull request:<br class="">
>>>>> <a href="https://github.com/wildfly/wildfly-archetypes/pull/3" rel="noreferrer" target="_blank" class="">https://github.com/wildfly/wildfly-archetypes/pull/3</a><br class="">
>>>>> <br class="">
>>>>> There already exists a JIRA (created by myself):<br class="">
>>>>> <a href="https://issues.jboss.org/browse/WFLY-9703" rel="noreferrer" target="_blank" class="">https://issues.jboss.org/browse/WFLY-9703</a> - but I cannot assign it to<br class="">
>>>>> myself, probably because I only have the role "jira user".<br class="">
>>>>> <br class="">
>>>>> Next steps (if the pull request is accepted):<br class="">
>>>>> -someone has to release if to maven central. See the release scripts in<br class="">
>>>>> the wildfly-archetypes root. This is probably something that has to done<br class="">
>>>>> by the JBoss team.<br class="">
>>>>> -the old archetype can be removed.<br class="">
>>>>> -I will create a similar archetype replacement for<br class="">
>>>>> "wildfly-javaee7-webapp-archetype"<br class="">
>>>>> <br class="">
>>>>> <br class="">
>>>>> Wolfgang<br class="">
>>>>> <br class="">
>>>>> Am 19.03.19 um 12:09 schrieb Wolfgang Knauf:<br class="">
>>>>>> <br class="">
>>>>>> Am 18.03.19 um 22:49 schrieb Eduardo Martins:<br class="">
>>>>>>> Webapp-ear sounds a bit weird, perhaps app-ear and app-web instead? :-)<br class="">
>>>>>> <br class="">
>>>>>> <br class="">
>>>>>> What do you think about "wildfly-javaee-ear-archetype" and<br class="">
>>>>>> "wildfly-javaee-web-archetype"?<br class="">
>>>>>> <br class="">
>>>>>> <br class="">
>>>>>> Attached is a suggested integration test prototype, which shows how to<br class="">
>>>>>> create the EAR file using ShrinkWrap. The test code will be placed in<br class="">
>>>>>> the web module. The kitchensink quickstart had the tests in the EJB jar,<br class="">
>>>>>> but this is the wrong place if you also want to test the web layer.<br class="">
>>>>>> <br class="">
>>>>>> If this is all sound OK, I will start committing it to my git repository<br class="">
>>>>>> and sending the pull request.<br class="">
>>>>>> <br class="">
>>>>>> Best regards<br class="">
>>>>>> <br class="">
>>>>>> Wolfgang<br class="">
>>>>>> <br class="">
>>>>>>> <br class="">
>>>>>>> On Mon, 18 Mar 2019 at 21:04, Wolfgang Knauf <<a href="mailto:wolfgang.knauf@gmx.de" target="_blank" class="">wolfgang.knauf@gmx.de</a><br class="">
>>>>>>> <mailto:<a href="mailto:wolfgang.knauf@gmx.de" target="_blank" class="">wolfgang.knauf@gmx.de</a>>> wrote:<br class="">
>>>>>>> <br class="">
>>>>>>> OK, so there are two votes (mine and Eduardo's) for "create a blank<br class="">
>>>>>>> archetype from scratch - no demo source included" and no vote for<br class="">
>>>>>>> "continue using the quickstart" approach.<br class="">
>>>>>>> <br class="">
>>>>>>> Currently, I struggle with the archetype and will send a pull<br class="">
>>>>>>> request in<br class="">
>>>>>>> the next few days.<br class="">
>>>>>>> <br class="">
>>>>>>> Any objections against the name<br class="">
>>>>>>> "wildfly-javaee-webapp-ear-archetype"<br class="">
>>>>>>> (which means: a new subdirectory in git)?<br class="">
>>>>>>> <br class="">
>>>>>>> If this is done, the next step would be to create a<br class="">
>>>>>>> "wildfly-javaee-webapp-archetype". And then someone could clean<br class="">
>>>>>>> up the<br class="">
>>>>>>> old archetypes.<br class="">
>>>>>>> <br class="">
>>>>>>> I think about adding a small integration test to the web project<br class="">
>>>>>>> which<br class="">
>>>>>>> shows how to create the @Deployment using ShrinkWrap? The test<br class="">
>>>>>>> itself<br class="">
>>>>>>> might have only dummy code, just the creation of the EAR file is<br class="">
>>>>>>> relevant. This might be helpful to users.<br class="">
>>>>>>> <br class="">
>>>>>>> Best regards<br class="">
>>>>>>> <br class="">
>>>>>>> Wolfgang<br class="">
>>>>>>> <br class="">
>>>>>>> Am 18.03.19 um 09:33 schrieb Eduardo Martins:<br class="">
>>>>>>>> The archetype sources should actually be simpler to maintain, no<br class="">
>>>>>>> need to “fix” the imported QS sources... I guess for most releases<br class="">
>>>>>>> it would be to simply the effort to sync some dependency management<br class="">
>>>>>>> versions for the generated parent pom, e.g. WildFly BOMs version.<br class="">
>>>>>>>> <br class="">
>>>>>>>> Wrt the html5-mobile archetype, I believe it is similar to the<br class="">
>>>>>>> ones you were looking at, but pointing to an old QS that was<br class="">
>>>>>>> removed<br class="">
>>>>>>> at some point.<br class="">
>>>>>>>> <br class="">
>>>>>>>> —E<br class="">
>>>>>>>> <br class="">
>>>>>>>>> On 13 Mar 2019, at 19:14, Wolfgang Knauf <<a href="mailto:wolfgang.knauf@gmx.de" target="_blank" class="">wolfgang.knauf@gmx.de</a><br class="">
>>>>>>> <mailto:<a href="mailto:wolfgang.knauf@gmx.de" target="_blank" class="">wolfgang.knauf@gmx.de</a>>> wrote:<br class="">
>>>>>>>>> <br class="">
>>>>>>>>> <br class="">
>>>>>>>>> Am 13.03.19 um 18:25 schrieb Eduardo Martins:<br class="">
>>>>>>>>>> <br class="">
>>>>>>>>>>> On 12 Mar 2019, at 19:12, Wolfgang Knauf<br class="">
>>>>>>> <<a href="mailto:wolfgang.knauf@gmx.de" target="_blank" class="">wolfgang.knauf@gmx.de</a> <mailto:<a href="mailto:wolfgang.knauf@gmx.de" target="_blank" class="">wolfgang.knauf@gmx.de</a>>> wrote:<br class="">
>>>>>>>>>>> <br class="">
>>>>>>>>>>> Hi Eduardo,<br class="">
>>>>>>>>>>> <br class="">
>>>>>>>>>>> Am 12.03.19 um 08:58 schrieb Eduardo Martins:<br class="">
>>>>>>>>>>>> Hi Wolfgang, the kitchensink QS truly depends on the QS<br class="">
>>>>>>> parent pom (dependency management, plugins, etc.), which means that<br class="">
>>>>>>> if we replace it with a “local” parent pom then, for each release,<br class="">
>>>>>>> we need to sync manually such parents poms content… I don’t see any<br class="">
>>>>>>> issue with using QS parent pom, it seems that those archetypes were<br class="">
>>>>>>> designed to generate clones of specific quickstarts with just<br class="">
>>>>>>> different Maven GAVs. Have you tried to install the SNAPSHOT<br class="">
>>>>>>> versioned QS parent first (mvn install -N at QS repo root), or<br class="">
>>>>>>> use a<br class="">
>>>>>>> tag such as 16.0.0.Final, which parent was released to Maven,<br class="">
>>>>>>> instead of pointing to QS master branch ?<br class="">
>>>>>>>>>>>> Honestly I’m not sure this kind of app archetype is of much<br class="">
>>>>>>> interest as it is, mostly due to the app's complexity, probably<br class="">
>>>>>>> would be more helpful almost “empty” apps, but if the idea is to<br class="">
>>>>>>> have a QS clone tool then perhaps a single generic archetype for<br class="">
>>>>>>> that would make more sense. I’m open to QS source changes needed to<br class="">
>>>>>>> be friendly with such archetype :-)<br class="">
>>>>>>>>>>>> —E<br class="">
>>>>>>>>>>> <br class="">
>>>>>>>>>>> <br class="">
>>>>>>>>>>> I agree that the "wildfly-javaee7-webapp-ear-archetype"<br class="">
>>>>>>> archetype is not really useful. But based on this archetype, an<br class="">
>>>>>>> empty archetype "wildfly-javaee7-webapp-ear-blank-archetype" is<br class="">
>>>>>>> generated, which consists of all necessary pom.xml files and some<br class="">
>>>>>>> deployment descriptor stubs. And *this* archetype is the reason why<br class="">
>>>>>>> I started working on it: it is a good starting point for a new<br class="">
>>>>>>> JavaEE application which already defines all necessary components.<br class="">
>>>>>>>>>>> <br class="">
>>>>>>>>>>> I am willing to maintain this archetype for the next few<br class="">
>>>>>>> years<br class="">
>>>>>>> and trying to release a version for each major WildFly version. As<br class="">
>>>>>>> suggested I would add a static root pom.xml to the archetype github<br class="">
>>>>>>> project which is independent of the quickstart files, as they are<br class="">
>>>>>>> not "standalone". This main pom.xml has to be updated for each<br class="">
>>>>>>> WildFly version, but all the other files still can be pulled from<br class="">
>>>>>>> the "KitchensinkEar" quickstart.<br class="">
>>>>>>>>>>> <br class="">
>>>>>>>>>> <br class="">
>>>>>>>>>> Then why get any sources from QS repo, having a proper<br class="">
>>>>>>> do-nothing app project all locally sounds better to me, probably<br class="">
>>>>>>> less effort needed on every release too.<br class="">
>>>>>>>>>> <br class="">
>>>>>>>>>> —E<br class="">
>>>>>>>>>> <br class="">
>>>>>>>>> <br class="">
>>>>>>>>> So you prefer to create a blank archetype which has no build<br class="">
>>>>>>>>> dependencies, just containing the relevant pom.xml files and<br class="">
>>>>>>> maybe some<br class="">
>>>>>>>>> required files (don't know if there are any)? And this<br class="">
>>>>>>> archetype is<br class="">
>>>>>>>>> updated by someone (e.g. me) each time a new major release<br class="">
>>>>>>> is done?<br class="">
>>>>>>>>> <br class="">
>>>>>>>>> Same applies to the other archetype,<br class="">
>>>>>>> "wildfly-javaee7-webapp-archetype”.<br class="">
>>>>>>>>> The wildfly-archetypes project contains two more archetypes<br class="">
>>>>>>>>> ("wildfly-html5-mobile-archetype",<br class="">
>>>>>>> "wildfly-subsystem-archetype"), but I<br class="">
>>>>>>>>> did not even take a look at those.<br class="">
>>>>>>>>> <br class="">
>>>>>>>>> Personally, I prefer the standalone approach, too. It means<br class="">
>>>>>>> more<br class="">
>>>>>>> work to<br class="">
>>>>>>>>> maintain it, but it is simpler ;-)<br class="">
>>>>>>>>> <br class="">
>>>>>>>>> Please vote for any of those solutions ;-):<br class="">
>>>>>>>>> a) continue pulling from KitchensinkEAR quickstart ("blank"<br class="">
>>>>>>> archetype<br class="">
>>>>>>>>> and archetype with a basic project)...<br class="">
>>>>>>>>> b) create standalone archetype (only "blank" archetype).<br class="">
>>>>>>>>> <br class="">
>>>>>>>>> <br class="">
>>>>>>>>> Best regards<br class="">
>>>>>>>>> <br class="">
>>>>>>>>> Wolfgang<br class="">
>>>>>> <br class="">
>>>>>> _______________________________________________<br class="">
>>>>>> wildfly-dev mailing list<br class="">
>>>>>> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank" class="">wildfly-dev@lists.jboss.org</a><br class="">
>>>>>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank" class="">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br class="">
>>>>>> <br class="">
>>>> <br class="">
>>>> _______________________________________________<br class="">
>>>> wildfly-dev mailing list<br class="">
>>>> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank" class="">wildfly-dev@lists.jboss.org</a><br class="">
>>>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank" class="">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br class="">
>>> <br class="">
>>> <br class="">
>> <br class="">
>> _______________________________________________<br class="">
>> wildfly-dev mailing list<br class="">
>> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank" class="">wildfly-dev@lists.jboss.org</a><br class="">
>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank" class="">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br class="">
> <br class="">
<br class="">
</blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail-m_6500438122771242479m_4870920467673897466gmail_signature"><div dir="ltr" class="">Brian Stansberry<div class="">Manager, Senior Principal Software Engineer</div><div class="">Red Hat</div></div></div>
</blockquote></div></div>
</blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail_signature"><div dir="ltr" class="">Brian Stansberry<div class="">Manager, Senior Principal Software Engineer</div><div class="">Red Hat</div></div></div>
</div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></body></html>