<div dir="ltr"><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">When you review <a href="https://github.com/wildfly/wildfly/pull/12538">https://github.com/wildfly/wildfly/pull/12538</a> if you approve it please use the Git Hub approval feature[1] to do so. It's nice to see in the top right corner of that page who has approved vs scrolling for comments.</div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><br></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">(This is true for all PRs.)</div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><br></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">[1] <a href="https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/reviewing-proposed-changes-in-a-pull-request#submitting-your-review" style="font-family:Arial,Helvetica,sans-serif">https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/reviewing-proposed-changes-in-a-pull-request#submitting-your-review</a></div><div class="gmail_default" style="font-family:trebuchet ms,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 15, 2020 at 8:18 AM Jean-Frederic Mesnil <<a href="mailto:jmesnil@redhat.com">jmesnil@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">With WFCORE-4150[1], we have added a new feature to automatically add and update credentials in a credential store.<br>
<br>
This new RFE has been enabled in WildFly Core 12.0.0.Beta1 that was released last week.<br>
However for users to be able to use this feature, we must update the subsystems API and XML Schemas to expose this new feature.<br>
<br>
This require to bump the version of existing XSD schemas to reference the new namespace "urn:wildfly:credential-reference:1.1" (instead of the previous "urn:wildfly:credential-reference:1.0”).<br>
<br>
Concerned extensions are:<br>
* clustering<br>
* datasources<br>
* resource-adapters<br>
* agroal<br>
* mail<br>
* messaging-activemq<br>
* undertow<br>
<br>
We need to update ALL use of credential-reference in our subsystems to provide a consistent user experience to our users.<br>
Farah already did most of the work for it in <a href="https://github.com/wildfly/wildfly/pull/12538" rel="noreferrer" target="_blank">https://github.com/wildfly/wildfly/pull/12538</a>.<br>
<br>
I’d like to get all component leads for the impacted subsystems to review her PR so we can merge it early in the release cycle of WildFly 20.<br>
<br>
Could the component leads for these subsystems (I’ve put you in CC if you are concerned) review Farah PR and ack/nack it before the end of this week, please?<br>
<br>
Thanks for you help,<br>
Jeff<br>
<br>
[1] <a href="https://issues.jboss.org/browse/WFCORE-4150" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/WFCORE-4150</a><br>
--<br>
Jeff Mesnil<br>
Principal Software Engineer<br>
Red Hat<br>
<a href="http://jmesnil.net/" rel="noreferrer" target="_blank">http://jmesnil.net/</a><br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div>