[Windup-commits] [windup/windup] 473f8b: WINDUP-1677 inconsistent type value annotations (#...

[David Klingenberg]

  Branch: refs/heads/master
  Home:   https://github.com/windup/windup
  Commit: 473f8bfee811ad3b06739fc88b62c922236aae23
      https://github.com/windup/windup/commit/473f8bfee811ad3b06739fc88b62c922236aae23
  Author: David Klingenberg <dklingenberg at gmail.com>
  Date:   2017-09-15 (Fri, 15 Sep 2017)

  Changed paths:
    M graph/api/src/main/java/org/jboss/windup/graph/model/ApplicationArchiveModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/ApplicationModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/ArchiveModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/DuplicateArchiveModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/DuplicateProjectModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/FileLocationModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/FileReferenceModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/OrganizationModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/ProjectDependencyModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/WindupConfigurationModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/WindupExecutionModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/report/IgnoredFileRegexModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/resource/FileModel.java
    M graph/api/src/main/java/org/jboss/windup/graph/model/resource/ReportResourceFileModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/ApplicationReportIndexModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/ApplicationReportModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/ClassificationModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/EffortReportModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/FreeMarkerSourceReportModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/InlineHintModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/MigrationIssuesReportModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/QuickfixModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/ReplacementQuickfixModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/ReportModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/TechnologyTagModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/TransformationQuickfixModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/rule/ExecutionPhaseModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/rule/RuleExecutionModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/rule/RuleProviderModel.java
    M reporting/api/src/main/java/org/jboss/windup/reporting/model/source/SourceReportToProjectEdgeModel.java
    M rules-java-archives/addon/src/main/java/org/jboss/windup/rules/apps/java/archives/model/ArchiveCoordinateModel.java
    M rules-java-archives/addon/src/main/java/org/jboss/windup/rules/apps/java/archives/model/IdentifiedArchiveModel.java
    M rules-java-archives/addon/src/main/java/org/jboss/windup/rules/apps/java/archives/model/IgnoredArchiveModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/DataSourceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/EjbEntityBeanModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/EjbMessageDrivenModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/EjbRemoteServiceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/EjbSessionBeanModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/EnvironmentReferenceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/HibernateEntityModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/HibernateSessionFactoryModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/JNDIResourceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/JPAEntityModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/JPANamedQueryModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/JPAPersistenceUnitModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/JaxRPCWebServiceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/JaxRSWebServiceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/JaxWSWebServiceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/JdbcDatasourceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/JspSourceFileModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/PersistenceEntityModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/RMIServiceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/RemoteServiceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/WebServiceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/WebXmlModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/WebXmlResourceReferenceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/association/JNDIReferenceModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/association/VendorSpecificationExtensionModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/stats/GeneralStatsItemModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/stats/GeneralStatsModel.java
    M rules-java-ee/addon/src/main/java/org/jboss/windup/rules/apps/javaee/model/stats/TechnologyUsageStatisticsModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/dependencyreport/DependenciesReportModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/dependencyreport/DependencyReportDependencyGroupModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/dependencyreport/DependencyReportToArchiveEdgeModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/AmbiguousJavaClassModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/AmbiguousReferenceModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/EarArchiveModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/HasManifestFilesModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/IgnoredFilesReportModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/JarArchiveModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/JarManifestModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/JavaApplicationOverviewReportModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/JavaClassModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/JavaMethodModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/JavaParameterModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/PackageModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/PhantomJavaClassModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/WarArchiveModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/model/project/MavenProjectModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/reporting/rules/UnparsablesAppReportModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/scan/ast/JavaTypeReferenceModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/scan/ast/annotations/JavaAnnotationTypeReferenceModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/java/scan/ast/annotations/JavaAnnotationTypeValueModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/mavenize/GlobalBomModel.java
    M rules-java/api/src/main/java/org/jboss/windup/rules/apps/mavenize/PomXmlModel.java
    M rules-xml/api/src/main/java/org/jboss/windup/rules/apps/xml/model/DoctypeMetaModel.java
    M rules-xml/api/src/main/java/org/jboss/windup/rules/apps/xml/model/NamespaceMetaModel.java
    M rules-xml/api/src/main/java/org/jboss/windup/rules/apps/xml/model/XmlTypeReferenceModel.java
    M rules-xml/api/src/main/java/org/jboss/windup/rules/apps/xml/model/XsltTransformationModel.java

  Log Message:
  -----------
  WINDUP-1677 inconsistent type value annotations (#1170)

* Make TypeValue consistent

* Remove TYPE prefix, no collision found

* Use "-" delimiter instead of ":"

* Replace hardcoded string by variable

* Model inconsistency