<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Let's move this discussion to <br>
<a class="moz-txt-link-freetext" href="https://issues.jboss.org/browse/WINDUP-97?jql=project%20%3D%20WINDUP">https://issues.jboss.org/browse/WINDUP-97?jql=project%20%3D%20WINDUP</a><br>
<br>
Ondra<br>
<br>
<br>
<div class="moz-cite-prefix">On 26.6.2014 04:20, Ondrej Zizka wrote:<br>
</div>
<blockquote cite="mid:53AB837D.8000800@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
It seems that the interface could be reduced from<br>
<br>
public interface IterationSelectionManager {<br>
Iterable<WindupVertexFrame> getFrames(GraphRewrite
event, VarStack varStack);<br>
}<br>
<br>
to just<br>
<br>
public interface FramesSelector {<br>
Iterable<WindupVertexFrame> getFrames();<br>
}<br>
<br>
Because:<br>
<br>
1) Has not much to do with iteration<br>
2) the stack and the event do not necessarily have to be needed /
available at the time of calling getFrames(),<br>
3) event is used just to get the context, which may be set in
impl's constructor (or injected?),<br>
4) The variables stack should be accessible from the context, i.e.
somehow from the event. and if not, 3) applies here too.<br>
<br>
WDYT?<br>
<br>
Ondra<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 26.6.2014 03:39, Ondrej Zizka
wrote:<br>
</div>
<blockquote cite="mid:53AB79E8.3060305@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 25.6.2014 08:04, Lincoln Baxter, III wrote:<br>
<blockquote
cite="mid:CAEp_U4FK0XxcSHfjSSeUO9wtfYQC9TzU-1p05Z3jyjQxTtPn0Q@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>IterationSelectionManager provides access to the
specified selection variable (e.g. something that was
selected via GraphSearchConditionBuilder (this name was
initially "Selection" and we probably need to think about
changing the name to something else)</div>
</div>
</blockquote>
It's rather some kind of view/projection than a manager - the
SelectionFactory / VarStack actually manages both.<br>
And I ponder how many ways to get the frames based on a name can
there be. Can one var name lead to different set frames? If not,
then that's my point - if there's just one, then this layer is
not necessary. Or do I miss something?<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
windup-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/windup-dev">https://lists.jboss.org/mailman/listinfo/windup-dev</a></pre>
</blockquote>
<br>
</body>
</html>