<div dir="ltr">I do remember this discussion, and I think that while it's one possible solution, it's not really beneficial to have the separated out into non-java files. In this particular scenario, I do think that writing multiple rules is probably not what we want, but we do probably want to keep the data in Java, in the ConfigurationProvider or a closely related class.<div>
<br></div><div>Matej was just doing what he thought we asked him to do, literally port the rules 1:1. He now understands we meant "port the functionality." :)</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, Jul 15, 2014 at 12:31 PM, Ondrej Zizka <span dir="ltr"><<a href="mailto:ozizka@redhat.com" target="_blank">ozizka@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
just a note on $SUBJ. I may be wrong, but I recall we agreed that the<br>
old rules, since being so monotonous, could have one rule, which would<br>
load the simple data from a static file(s), and one rule which would<br>
execute them. E.g. a simple .csv file with regex, hint, reference. Or<br>
JSON/XML if needed.<br>
<br>
Now Matej creates one java rule per each legacy regex.<br>
Is there some change in the previous plan?<br>
Both solutions have obvious advantages, I just want to know what was the<br>
decision.<br>
<br>
Thanks,<br>
Ondra<br>
_______________________________________________<br>
windup-dev mailing list<br>
<a href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."
</div>