<div dir="ltr">Hey Bruno,<div><br></div><div>Yeah, we definitely plan on externalizing this, but I'd rather not just create a separate data format just to keep this stuff out of java (I'd rather implement it properly via the Groovy simplified rule stuff, which this is a prerequisite for.</div>
<div><br></div><div>My only point here is that I see little difference between putting strings in a .CSV file and in a Java file considering we'll be exposing this in groovy anyway :)</div><div><br></div><div>~Lincoln </div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 15, 2014 at 5:35 PM, Bruno Georges <span dir="ltr"><<a href="mailto:bgeorges@redhat.com" target="_blank">bgeorges@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Thinking out loud, having the ability to externalise rules is a big plus imo, I recall my years writing <a href="http://simplybusiness.co.uk" target="_blank">simplybusiness.co.uk</a> 's Quotation engine, having rules in Java was not ideal at all.<div>
Hence, I am still a proponent of this approach. It has many advantages, productivity/testability are 2 of them. </div><div><br></div><div>my 2 cents.</div><span class="HOEnZb"><font color="#888888"><div><br></div></font></span><div>
<span class="HOEnZb"><font color="#888888">Bruno</font></span><div><div class="h5"><br><div><div>On 16/07/2014, at 6:10 am, Lincoln Baxter, III <<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr">I do remember this discussion, and I think that while it's one possible solution, it's not really beneficial to have the separated out into non-java files. In this particular scenario, I do think that writing multiple rules is probably not what we want, but we do probably want to keep the data in Java, in the ConfigurationProvider or a closely related class.<div>
<br></div><div>Matej was just doing what he thought we asked him to do, literally port the rules 1:1. He now understands we meant "port the functionality." :)</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, Jul 15, 2014 at 12:31 PM, Ondrej Zizka <span dir="ltr"><<a href="mailto:ozizka@redhat.com" target="_blank">ozizka@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
just a note on $SUBJ. I may be wrong, but I recall we agreed that the<br>
old rules, since being so monotonous, could have one rule, which would<br>
load the simple data from a static file(s), and one rule which would<br>
execute them. E.g. a simple .csv file with regex, hint, reference. Or<br>
JSON/XML if needed.<br>
<br>
Now Matej creates one java rule per each legacy regex.<br>
Is there some change in the previous plan?<br>
Both solutions have obvious advantages, I just want to know what was the<br>
decision.<br>
<br>
Thanks,<br>
Ondra<br>
_______________________________________________<br>
windup-dev mailing list<br>
<a href="mailto:windup-dev@lists.jboss.org" target="_blank">windup-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.org/" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."
</div>
_______________________________________________<br>windup-dev mailing list<br><a href="mailto:windup-dev@lists.jboss.org" target="_blank">windup-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a></blockquote>
</div><br></div></div></div></div><br>_______________________________________________<br>
windup-dev mailing list<br>
<a href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Lincoln Baxter, III<br>
<a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."
</div>