<div dir="ltr">The rule executor (RuleSubset) could actually handle doing this I think. For each rule it executes, set the ID, the version, and the phase in the graph (and possibly also a stringification of what the rule consists of)</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 22, 2014 at 10:09 AM, Jess Sightler <span dir="ltr"><<a href="mailto:jsightle@redhat.com" target="_blank">jsightle@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Oh, I see... if we are going to do this, I could see it having a few things:<br>
<br>
1. RuleID - A string uniquely identifying the rule<br>
2. Rule Version - The version of the addon containing the rule<br>
3. RulePhase - The phase during which the rule was run<br>
<br>
I don't think that this belongs in reporting, though. I am also not sure<br>
how easy it would be to automate the population of these fields, though<br>
it might be possible with some tweaks to frames.<br>
<div class="HOEnZb"><div class="h5"><br>
On 07/21/2014 08:59 PM, Ondrej Zizka wrote:<br>
> So far, an ID and a reference to the Ruleset. The ruleset then would<br>
> probably have further info, like, version etc.<br>
><br>
> <a href="https://github.com/OndraZizka/windup/blob/3940b146f811ab6e5fff1cb6c6def7179a33a467/reporting/api/src/main/java/org/jboss/windup/reporting/model/RuleModel.java" target="_blank">https://github.com/OndraZizka/windup/blob/3940b146f811ab6e5fff1cb6c6def7179a33a467/reporting/api/src/main/java/org/jboss/windup/reporting/model/RuleModel.java</a><br>
><br>
> Anyway, even if it was just an ID, OOP principles suggest to encapsulate<br>
> that ID to a type. My experience agrees. I may be wrong though.<br>
><br>
> Ondra<br>
><br>
><br>
> On 22.7.2014 02:40, Jess Sightler wrote:<br>
>> I'm not opposed to this idea... except that I don't know what a<br>
>> "RuleModel" would actually contain, other than the ID.<br>
>><br>
>> What are you proposing it to contain?<br>
>><br>
>> On 07/21/2014 07:03 PM, Ondrej Zizka wrote:<br>
>>> We should have $subj:<br>
>>><br>
>>> We need to refer to the rules in the report.<br>
>>> We agreed to store all information in the graph.<br>
>>> Current ID is not guaranteed to be the same over runs.<br>
>>> Current ID has no namespaces.<br>
>>><br>
>>> my2c.<br>
>>> Ondra<br>
>>><br>
>>> _______________________________________________<br>
>>> windup-dev mailing list<br>
>>> <a href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
>> _______________________________________________<br>
>> windup-dev mailing list<br>
>> <a href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
> _______________________________________________<br>
> windup-dev mailing list<br>
> <a href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
<br>
_______________________________________________<br>
windup-dev mailing list<br>
<a href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."
</div>