<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    But how does it know which vertices were created (or modified) by
    that rule?<br>
    <br>
    <div class="moz-cite-prefix">On 07/22/2014 10:57 AM, Lincoln Baxter,
      III wrote:<br>
    </div>
    <blockquote
cite="mid:CAEp_U4HiwHm436i39CveBVLdE4t8ubnczesOfjqeOsN4phdceg@mail.gmail.com"
      type="cite">
      <div dir="ltr">The rule executor (RuleSubset) could actually
        handle doing this I think. For each rule it executes, set the
        ID, the version, and the phase in the graph (and possibly also a
        stringification of what the rule consists of)</div>
      <div class="gmail_extra"><br>
        <br>
        <div class="gmail_quote">On Tue, Jul 22, 2014 at 10:09 AM, Jess
          Sightler <span dir="ltr">&lt;<a moz-do-not-send="true"
              href="mailto:jsightle@redhat.com" target="_blank">jsightle@redhat.com</a>&gt;</span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">Oh, I
            see... if we are going to do this, I could see it having a
            few things:<br>
            <br>
            1. RuleID - A string uniquely identifying the rule<br>
            2. Rule Version - The version of the addon containing the
            rule<br>
            3. RulePhase - The phase during which the rule was run<br>
            <br>
            I don't think that this belongs in reporting, though. I am
            also not sure<br>
            how easy it would be to automate the population of these
            fields, though<br>
            it might be possible with some tweaks to frames.<br>
            <div class="HOEnZb">
              <div class="h5"><br>
                On 07/21/2014 08:59 PM, Ondrej Zizka wrote:<br>
                &gt; So far, an ID and a reference to the Ruleset. The
                ruleset then would<br>
                &gt; probably have further info, like, version etc.<br>
                &gt;<br>
                &gt; <a moz-do-not-send="true"
href="https://github.com/OndraZizka/windup/blob/3940b146f811ab6e5fff1cb6c6def7179a33a467/reporting/api/src/main/java/org/jboss/windup/reporting/model/RuleModel.java"
                  target="_blank">https://github.com/OndraZizka/windup/blob/3940b146f811ab6e5fff1cb6c6def7179a33a467/reporting/api/src/main/java/org/jboss/windup/reporting/model/RuleModel.java</a><br>
                &gt;<br>
                &gt; Anyway, even if it was just an ID, OOP principles
                suggest to encapsulate<br>
                &gt; that ID to a type. My experience agrees. I may be
                wrong though.<br>
                &gt;<br>
                &gt; Ondra<br>
                &gt;<br>
                &gt;<br>
                &gt; On 22.7.2014 02:40, Jess Sightler wrote:<br>
                &gt;&gt; I'm not opposed to this idea... except that I
                don't know what a<br>
                &gt;&gt; "RuleModel" would actually contain, other than
                the ID.<br>
                &gt;&gt;<br>
                &gt;&gt; What are you proposing it to contain?<br>
                &gt;&gt;<br>
                &gt;&gt; On 07/21/2014 07:03 PM, Ondrej Zizka wrote:<br>
                &gt;&gt;&gt; We should have $subj:<br>
                &gt;&gt;&gt;<br>
                &gt;&gt;&gt; We need to refer to the rules in the
                report.<br>
                &gt;&gt;&gt; We agreed to store all information in the
                graph.<br>
                &gt;&gt;&gt; Current ID is not guaranteed to be the same
                over runs.<br>
                &gt;&gt;&gt; Current ID has no namespaces.<br>
                &gt;&gt;&gt;<br>
                &gt;&gt;&gt; my2c.<br>
                &gt;&gt;&gt; Ondra<br>
                &gt;&gt;&gt;<br>
                &gt;&gt;&gt;
                _______________________________________________<br>
                &gt;&gt;&gt; windup-dev mailing list<br>
                &gt;&gt;&gt; <a moz-do-not-send="true"
                  href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
                &gt;&gt;&gt; <a moz-do-not-send="true"
                  href="https://lists.jboss.org/mailman/listinfo/windup-dev"
                  target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
                &gt;&gt; _______________________________________________<br>
                &gt;&gt; windup-dev mailing list<br>
                &gt;&gt; <a moz-do-not-send="true"
                  href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
                &gt;&gt; <a moz-do-not-send="true"
                  href="https://lists.jboss.org/mailman/listinfo/windup-dev"
                  target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
                &gt; _______________________________________________<br>
                &gt; windup-dev mailing list<br>
                &gt; <a moz-do-not-send="true"
                  href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
                &gt; <a moz-do-not-send="true"
                  href="https://lists.jboss.org/mailman/listinfo/windup-dev"
                  target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
                <br>
                _______________________________________________<br>
                windup-dev mailing list<br>
                <a moz-do-not-send="true"
                  href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
                <a moz-do-not-send="true"
                  href="https://lists.jboss.org/mailman/listinfo/windup-dev"
                  target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
              </div>
            </div>
          </blockquote>
        </div>
        <br>
        <br clear="all">
        <div><br>
        </div>
        -- <br>
        Lincoln Baxter, III<br>
        <a moz-do-not-send="true" href="http://ocpsoft.org"
          target="_blank">http://ocpsoft.org</a><br>
        "Simpler is better."
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
windup-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/windup-dev">https://lists.jboss.org/mailman/listinfo/windup-dev</a></pre>
    </blockquote>
    <br>
  </body>
</html>