<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
If I may state my humble opinion:<br>
<br>
1) users, even java-based ruleset authors, do not care l about how
ugly our internal code is :)<br>
1b) I like single concise class with few entries more than a
pack of 5-line .java files.<br>
<br>
2) RulePhase.<Ctrl+space> is much much quicker than looking up
the information.<br>
The thing is, that our users do not even know that there's some
superclass they can look for, they will just copy the quickstarts,
and seeing <br>
RulePhase.Initial.class suggests very clearly that there are more to
pick from in RulePhase. Whereas "InitialPhase.class" doesn't.<br>
<br>
3) Keeping them in one file will make it easier for us to maintain -
the order will be hinted by the order of appearance, and potential
errors getExecuteAfter() will be more obvious.<br>
<br>
my2c.<br>
Ondra<br>
<br>
<br>
<div class="moz-cite-prefix">On 27.1.2015 04:39, Lincoln Baxter, III
wrote:<br>
</div>
<blockquote
cite="mid:CAEp_U4EfAMq6ezE94V1CUR0xUWr6U0fie6cDSWcWhSCWJ7vhHA@mail.gmail.com"
type="cite">
<div dir="ltr">Hey, good question, but no. You can always look in
that package and see all of the phases we have. Or use the IDE
to quick-search for types implementing RulePhase, etc. Not worth
making ugly code for that when the IDE or GitHub will tell you
exactly the same information.</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Jan 26, 2015 at 10:04 AM,
Ondrej Zizka <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:ozizka@redhat.com" target="_blank">ozizka@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hi,<br>
<br>
I am updating the quickstarts to match the recent changes<br>
<a moz-do-not-send="true"
href="https://issues.jboss.org/browse/WINDUP-277"
target="_blank">WINDUP-277</a> <a
moz-do-not-send="true"
href="https://issues.jboss.org/browse/WINDUP-277"
target="_blank">Replace Migration "Phases" with
dependencies</a> .<br>
<br>
The subclasses are small and just a few.<br>
Could we move them as inner classes of RulePhase?<br>
This would be beneficial:<br>
1) One could write "RulePhase." to get a list of built-in
phases instead of going to the documentation.<br>
2) We would get rid of several small .java files<br>
<br>
Ondra<br>
</div>
<br>
_______________________________________________<br>
windup-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/windup-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature">Lincoln Baxter, III<br>
<a moz-do-not-send="true" href="http://ocpsoft.org"
target="_blank">http://ocpsoft.org</a><br>
"Simpler is better."</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
windup-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/windup-dev">https://lists.jboss.org/mailman/listinfo/windup-dev</a></pre>
</blockquote>
<br>
</body>
</html>