<div dir="ltr">That said, you are right that as far as end users are concerned, having "perfect" code is not a requirement as long as it works, but I refuse to play the "deferred maintainance" / "code debt" game.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 28, 2015 at 1:00 PM, Lincoln Baxter, III <span dir="ltr"><<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Tue, Jan 27, 2015 at 10:48 PM, Ondrej Zizka <span dir="ltr"><<a href="mailto:ozizka@redhat.com" target="_blank">ozizka@redhat.com</a>></span> wrote:<br></span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class="">
If I may state my humble opinion:<br>
<br></span>
1) java-based ruleset authors do not care about how
ugly our internal code is :)<br></div></blockquote><div><br></div><div>I beg to differ, and I feel strongly that as a high-end software company, we need to present a *very* professional image. Even if it's "just internal code."</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">
2) RulePhase.<Ctrl+space> is much much quicker than looking up
the information.<br>
The thing is, that our users do not even know that there's some
superclass they can look for, they will just copy the quickstarts,
and seeing <br></div></blockquote><div><br></div></span><div><CTRL>-T</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">
RulePhase.Initial.class suggests very clearly that there are more to
pick from in RulePhase. Whereas "InitialPhase.class" doesn't.<br>
<br>
3) Keeping them in one file will make it easier for us to maintain</div></blockquote><div><br></div></span><div>Again I beg to differ.</div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><div><div>
<br>
<br>
<div>On 27.1.2015 04:39, Lincoln Baxter, III
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hey, good question, but no. You can always look in
that package and see all of the phases we have. Or use the IDE
to quick-search for types implementing RulePhase, etc. Not worth
making ugly code for that when the IDE or GitHub will tell you
exactly the same information.</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Jan 26, 2015 at 10:04 AM,
Ondrej Zizka <span dir="ltr"><<a href="mailto:ozizka@redhat.com" target="_blank">ozizka@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hi,<br>
<br>
I am updating the quickstarts to match the recent changes<br>
<a href="https://issues.jboss.org/browse/WINDUP-277" target="_blank">WINDUP-277</a> <a href="https://issues.jboss.org/browse/WINDUP-277" target="_blank">Replace Migration "Phases" with
dependencies</a> .<br>
<br>
The subclasses are small and just a few.<br>
Could we move them as inner classes of RulePhase?<br>
This would be beneficial:<br>
1) One could write "RulePhase." to get a list of built-in
phases instead of going to the documentation.<br>
2) We would get rid of several small .java files<br>
<br>
Ondra<br>
</div>
<br>
_______________________________________________<br>
windup-dev mailing list<br>
<a href="mailto:windup-dev@lists.jboss.org" target="_blank">windup-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div>Lincoln Baxter, III<br>
<a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>
"Simpler is better."</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
windup-dev mailing list
<a href="mailto:windup-dev@lists.jboss.org" target="_blank">windup-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a></pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
windup-dev mailing list<br>
<a href="mailto:windup-dev@lists.jboss.org" target="_blank">windup-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br></blockquote></div></div></div><div><div class="h5"><br><br clear="all"><div><br></div>-- <br><div>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."</div>
</div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."</div>
</div>