<div dir="ltr">We agreed the schema name will be:<div><br></div><div>windup-jboss-2.3.0.Final.xsd</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 26, 2015 at 8:46 PM, Ondrej Zizka <span dir="ltr"><<a href="mailto:ozizka@redhat.com" target="_blank">ozizka@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Sande, Marek,<br>
<br>
I know that all are used to -X_Y, but IMO it's a wrong tradition, let me<br>
explain why.<br>
<br>
The rule schema rules location will change with every change of the<br>
schema. The older schema needs to stay where it is. The old rules will<br>
refer to that schema. We might change our rules, but those rules which<br>
are outside our reach will have to refer to a valid schema URL.<br>
<br>
I remember that in QE dept, these a-b_c-D-e_F.G_h schemas were a source<br>
of bugs surprisingly often. Even your examples are inconsistent:<br>
<br>
<a href="http://www.jboss.org/schema/jbossas/jboss-as-logging_2_0.xsd" target="_blank">http://www.jboss.org/schema/jbossas/jboss-as-logging_2_0.xsd</a><br>
<a href="http://www.jboss.org/schema/jbossas/jboss-deployment-structure-1_2.xsd" target="_blank">http://www.jboss.org/schema/jbossas/jboss-deployment-structure-1_2.xsd</a><br>
<br>
<br>
Nobody really can tell why there's a - or _ or . .<br>
If we simply use the same version string and only use '-' before it,<br>
it's all clear.<br>
And, as I said - *the schema only expresses the constraint that is<br>
effectively inside of the released implementation*. So it's really<br>
*directly related to the particular release*.<br>
<br>
The fact that we would use 2.3.0.Final for a XSD url or namespace<br>
doesn't imply or suggest that it has to change for every release. The<br>
string is in 2 places so far, in general:<br>
1) The Windup source, where it should be a single constant in<br>
config-xml, referenced form it's dependees.<br>
2) The XML rules, where it can simply stay the same until next review of<br>
the rule.<br>
<br>
Therefore I don't think it would create any maintainance that would not<br>
be needed if we use arbitrary version string scheme.<br>
<br>
The only reason I can see to keep 1_1 is to align with what someone<br>
coined up 10 years ago, which for me equals to sticking to a wrong<br>
solution. YMMV :)<br>
<span class=""><br>
>> I am not really sure if it is good idea to have version in namespace<br>
</span>Is there some other way for versioning the schema and the rules?<br>
<span class="im HOEnZb"><br>
<br>
On 26.5.2015 20:13, Sande Gilda wrote:<br>
>>> 3) I suggest to align the XSD version with the Windup core version,<br>
>>> since the XSD describes what the core accepts.<br>
>>> "1.0" is not fortunate, as people will confuse it with legacy Windup.<br>
>>> The version string should be the same as Windup version, so we can<br>
>>> automate things. Different formats are source of human errors.<br>
> I went with _1_0.xsd to follow the patterns JBoss uses. If you look in<br>
> <a href="http://www.jboss.org/schema/jbossas/" target="_blank">http://www.jboss.org/schema/jbossas/</a>, you'll see none of the JBoss<br>
> related schemas use the JBoss EAP release number. For example:<br>
><br>
> <a href="http://www.jboss.org/schema/jbossas/jboss-as-mail_1_1.xsd" target="_blank">http://www.jboss.org/schema/jbossas/jboss-as-mail_1_1.xsd</a><br>
> <a href="http://www.jboss.org/schema/jbossas/jboss-as-logging_2_0.xsd" target="_blank">http://www.jboss.org/schema/jbossas/jboss-as-logging_2_0.xsd</a><br>
> <a href="http://www.jboss.org/schema/jbossas/jboss-deployment-structure-1_2.xsd" target="_blank">http://www.jboss.org/schema/jbossas/jboss-deployment-structure-1_2.xsd</a><br>
> <a href="http://www.jboss.org/schema/jbossas/jboss-ejb-client_1_2.xsd" target="_blank">http://www.jboss.org/schema/jbossas/jboss-ejb-client_1_2.xsd</a><br>
><br>
> Will the schema change with every release of Windup? I would expect it<br>
> to be more stable than that.<br>
><br>
> Won't it be a maintenance nightmare to update the rules schema location<br>
> in the XML for the rules for every release?<br>
<br>
</span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
windup-dev mailing list<br>
<a href="mailto:windup-dev@lists.jboss.org">windup-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/windup-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/windup-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."</div>
</div>