sounds good to me.

TBH, I found it quite confusing, seening that spring dependency in there, just because of BOM support

On Thu, Mar 29, 2018 at 11:08 PM, Daniel Passos <dpassos@redhat.com> wrote:

Hi,

While working on push stuff I figure out Spring dependency management[1] doesn’t work properly with Gradle transitive dependencies[2].

TL;DR It’s ignoring the transitive dependencies and on push, it causes some dependency conflicts. Since Google Services plugin doesn’t found any dependency it’s going to inject it from your on.

Android dependency 'com.google.firebase:firebase-iid' has different version for the compile (11.4.2) and runtime (12.0.1) classpath.

I’ve sent a PR[3] to remove it for now and revisit it in the future. I have moved all our dependencies version for a single file[4] like most of the libraries do.

This also will make us a little more fast and flexible to do changes in our dependencies.

Any thoughts?

[1] https://github.com/spring-gradle-plugins/dependency-management-plugin
[2] https://docs.gradle.org/current/userguide/managing_transitive_dependencies.html
[3] https://github.com/aerogear/aerogear-android-sdk/pull/173
[4] https://github.com/aerogear/aerogear-android-sdk/blob/master/constants.gradle

--
-- Passos

--
You received this message because you are subscribed to the Google Groups "Aerogear" group.
To unsubscribe from this group and stop receiving emails from it, send an email to aerogear+unsubscribe@googlegroups.com.
To post to this group, send email to aerogear@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/aerogear/CADF%3Dh2tqu_R1zY66YxPT2w6U-RdKqCJBfU%2BgtPihjyJEmKsmpg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.



--
Project lead AeroGear.org