--
abstractj

On February 17, 2014 at 12:21:45 PM, Matthias Wessendorf (matzew@apache.org) wrote:
>
> On Wed, Feb 12, 2014 at 3:15 PM, Bruno Oliveira

> wrote:
> > ### Some considerations
> >
> > - The key pair will be generated in a separated project, not on
> UPS
> > - For the key store I'm considering to support the same data stores
> > provided by SPS. What Dan did is a nice a idea (
> > https://github.com/aerogear/aerogear-simplepush-server/tree/master/datastores
> > )
> >
>
> You mean the new "key server" supports multiple databases, right
> ?

Basically the possibility to store those key pairs in whatever storage mechanism you want: memory, Redis…

TBH not very critical atm.

> > ## Changes suggested on UPS server
> >
> > 1. Login endpoint
> >
> > - Current login endpoint:
> >
> > POST /rest/auth/login
> >
> > - Suggested change:
> >
> > I'm not sure if we really need **POST** for login, unless
> > we are changing the state of some resource
> >
> > GET /rest/auth/login
> >
>
>
> Changing from POST to GET (for UPS login) is fine we me. The Login
> is
> really only relevant to the Admin UI.
> Historically: I picked POST because that's what all of our client
> libraries
> use as the default HTTP method for login (JS, iOS and Android)
> 

That’s more a suggestion than a deal breaker. 

> > 2. Register push app
> >
> > - Our push clients will need to change to accept the public key
> > provided by the server and encrypt the passphrase. We can make
> use of *AG
> > Crypto* for it
> > - The basic workflow for our clients would be:
> >
>
>
> What clients do you mean? The only thing that really does a login
> against
> the server is the Admin UI (or a direct curl, using the same 'management'
> rest-endpoints which are accessed by the AdminUI).
>
>

By clients I mean: cURL, aerogear-unifiedpush-java-client, node version…etc. If I got it right, you must provide the master secret.

The suggestion is not only protect our passphrases,

but also do not expose that masterSecret, because someone in possession of this could start to send push messages to the server. Am I wrong on it?