Sure, I'll try to improve the tests after refactoring the existing code and performing some changes that Bruno recommended.

Thanks,
Tolis


2014-03-18 10:26 GMT+02:00 Karel Piwko <kpiwko@redhat.com>:
Thanks Tolis, it looks good! We'd just need an additional test to verify
previous behavior is still valid, e.g. connection test was rewritten, it should
have been added next to http.

Many thanks!

Karel

On Mon, 17 Mar 2014 21:59:22 +0200
tolis emmanouilidis <tolisemm@gmail.com> wrote:

> To follow up, the JIRA id is AGPUSH-559 and I've sent a PR for supporting
> custom truststores [1]. The integration tests using SSL and the custom
> aerogear.truststore passed.
>
> [1]: https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/36
>
> Thanks,
> Tolis
>
>
> 2014-03-10 20:50 GMT+02:00 Matthias Wessendorf <matzew@apache.org>:
>
> >
> >
> > On Monday, March 10, 2014, Bruno Oliveira <bruno@abstractj.org> wrote:
> >
> >> JIRA is enough as far as I can tell.
> >
> >
> > +1 on JIRA for tracking
> >
> > feel free to send PR as well
> >
> > Greetings,
> > Matthias
> >
> >
> >>
> >> --
> >> abstractj
> >>
> >> On March 10, 2014 at 11:53:53 AM, Stefan Miklosovic (smikloso@redhat.com)
> >> wrote:
> >> > > Hi,
> >> >
> >> > so whats the "conclusion" for this? I would like to move forward
> >> > with other things. Is JIRA to track this sufficient?
> >> >
> >> > Stefan Miklosovic
> >> > Red Hat Brno - JBoss Mobile Platform
> >>
> >> _______________________________________________
> >> aerogear-dev mailing list
> >> aerogear-dev@lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >>
> >
> >
> > --
> > Sent from Gmail Mobile
> >
> > _______________________________________________
> > aerogear-dev mailing list
> > aerogear-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/aerogear-dev
> >

_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev