Hey Wojciech,
Thanks a lot for the feedback.
If I have understood you correctly, you are suggesting splitting this task in to two discrete pieces of work:
- Add parameters to oc cluster up, to be able to configure the ansible-service-broker with custom docker credentials and docker org to pull in the ASBs from.
- Add the —mobile flag to enable the Mobile-Core UI extension.
With the intention of making this an easier change to adopt.
If that is correct then I am happy to proceed this way and I can update the proposal to reflect this as a route to implementation.
Maybe it would be best to bring this discussion to the proposal so that the OpenShift team also have access to it?
Thanks,
Phil.On Fri, Jan 12, 2018 at 11:21 AM, Wojciech Trocki <wtrocki@redhat.com> wrote:Mobile flag as it doesn't provide ability to change values and imposes some hard dependencies.That may be hard accept and maintain on upstream.
Upstream works by generalization so if we want to contribute there it's best to pass something that can be used by many people.How about `oc cluster up --service-broker=true --service-broker-org=aerogearcatalog` and whatever else we need? That's easier to accept and contribute upstream.I have done changes for cluster up recently so if you need anything in that let me know - we can work on this together.
Another idea is to specify oc cluster up pre/post actions (hooks) that will allow people to run ansible roles for things we need.
That will be solid proposal that upstream may consider.
Developers can still have simple command by doing alias:alias oc-mobile-up=`oc cluster up --service-broker=true --service-broker-org=aerogearcatalog`
On Fri, Jan 12, 2018 at 10:51 AM, David Ffrench <dffrench@redhat.com> wrote:Fantastic Phil, This is 100% needed in my opinion. The mobile services need to be a first class citizen in OpenShift to ensure easy setup and adoption.On Fri, Jan 12, 2018 at 10:36 AM, Matthias Wessendorf <mwessend@redhat.com> wrote:+9001--On Fri, Jan 12, 2018 at 11:26 AM, Phil Brookes <pbrookes@redhat.com> wrote:Hey Everyone,
I have opened a proposal with the OpenShift team, hoping to start a discussion around the addition of a
--mobile=true
flag to theoc cluster up
command. Runningoc cluster up --mobile=true
will start a local OpenShift cluster with all of the MCP features enabled.This would be a great way for us to gain some exposure for the Mobile Core and get it into the hands of developers more quickly and easily, so I’d love to see you share your thoughts on this idea. You can review / comment / support it here:
https://github.com/openshift/origin/issues/18089 Thanks,
Phil.Project lead AeroGear.org
_______________________________________________
feedhenry-dev mailing list
feedhenry-dev@redhat.com
https://www.redhat.com/mailman/listinfo/feedhenry-dev
--