push.register(onNotification, errorHandler, {"badge": "true", "sound": "true", pushConfig: pushConfig});Now the Javascript can verify that the callback is a function because it’s no longer a string and the need for a separate successHandler is overrated as you will either get messages or your errorHandler gets invoked.True but it would be nice if we can still pass optionally a function for the registration successHandler, depending on the developer needs maybe I still wants to do something with his backend once the registration is suceesful. But I agree to have a default "hidden" function for that ... but should be able to override it.
For iOS we have these badge and sound flags we could we get rid of those as well? When you don’t want a badge then just don’t send it in the message!? Then the pushConfig can be inlined making it look like this:Not really understand here what you mean, could you elaborate a bit ?
push.register(onNotification, errorHandler, {// senderID is only used in the Android/GCM casesenderID: "<senderID e.g Google Project ID only for android>",pushServerURL: "<pushServerURL e.g http(s)//host:port/context >",variantID: "<variantID e.g. 1234456-234320>",variantSecret: "<variantSecret e.g. 1234456-234320>",alias: "<alias e.g. a username or an email address optional>"});Till now all these changes can be made on the plugin, but we could take it even further. Two things that are still platform dependent the senderId and the variantID/secret. Now senderId is ‘known’ by UPS so why do we need to specify it here? We could make senderId part of the response when registering a device on UPS then the client doesn’t need to specify it and all configuration is in one place.That will be a convention to skip the senderId when the variant is an Android "type", yeah why not, I like that.
That leaves variantID/secret and that is the boldest proposal. How about we make it possible to register for an application instead for a specific variant? Then based on the meta information (deviceType, operatingSystem and osVersion) we choose the right variant.I like the idea but that can be tricky since multiple variants can have the same meta information (like "Android Free"/"Android Premium"), we should think about a convention. But again I like the idea and it is worth thinking about it.