+1 too
also I like the idea of dropping "Java" in JavaSender for a more descriptive PushSender or PushAppSender to get the information this sender is linked to an Push app

++
Corinne

On 10 November 2014 08:31, Erik Jan de Wit <edewit@redhat.com> wrote:
+1 I like the static methods for creating the builder
Also makes perfect sense to make the applicationId and masterSecret part of the sender.

PushSender client = DefaultPushSender.withRootServerURL("http://aerogear.example.com/ag-push")
                .proxy("proxy", 8080)
                .proxyType(Proxy.Type.HTTP)
                .build();
PushSender client = DefaultPushSender.withConfig("/path/on/classpath/push-config.json").build();
PushSender client = DefaultPushSender.withConfig(inputstream).build();




_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev