On Sep 20, 2012, at 10:16 PM, Glen Daniels wrote:

Hey guys,

I figured that the Android stuff is sufficiently "prototypish" at this
phase that it wasn't hugely important to keep the history, which is why
I didn't merge over from
https://github.com/gdaniels/android-data/tree/master/android.  If we'd
rather have all the individual commits, I can do that (and if so,
merging an entire repo's commits into another one isn't something I've
done before, so I'd love pointers).

It is vitally important to keep history, especially when multiple contributors are involved.  If its you own prototype and no-one else is involved squash as you wish, but otherwise it's needed.

That said - we don't need every single commit ;-) Take a look at http://staging-aerogear.rhcloud.com/docs/guides/GitHubWorkflow/ for scoping/squashing commits.  


I'm not sure what the commit you referenced has to do with it, though,
Bruno?

I'll respond to qmx's other comments in a separate reply.

Thanks,
--Glen

On 9/20/12 9:38 PM, Bruno Oliveira wrote:
Comments inline….


--
"The measure of a man is what he does with power" - Plato
-
@abstractj
-
Volenti Nihil Difficile

On Thursday, September 20, 2012 at 10:29 PM, Douglas Campos wrote:

Howdy

I was reviewing aerogear-android-todo, and noticed some issues

1) Why there is no history on the project? (and consequently,
ownership history - passos contributed code hasn't got attribution)
- even in cases of big rewrites and start-overs, it's nice to keep the
commits, as the history of the incremental changes say a lot about the
rationale/train of thought that lead to the final solution
Really? What's happened? Have we lost our contributions? Weird because
at least on JavaScript, Kris has kept the
ownership https://github.com/aerogear/as-quickstarts/commit/f3fe1aa4274487f711615687ef55044d11bf384a

Why the same is not happening on android? Does anyone need help to do it?

My suggestion is revert it and rebase with our contributions.

2) Why aren't we following the maven project layout, as suggested by
the archetype we are using?
3) Why the API and the example app are intermixed?
- Ideally these should be separate repositories, like the iOS version

-- qmx


_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/aerogear-dev



_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev