don't insist on minimal changes :-)


you are modelling the message to send as one object and the recipients as two other (variant and tokens) parameters. it would be a natural enhancement to model the receivers in one object or - more similar to other apis like javax.mail - to integrate the receivers specification in the message object.






Von: aerogear-dev-bounces@lists.jboss.org [mailto:aerogear-dev-bounces@lists.jboss.org] Im Auftrag von Idel Pivnitskiy
Gesendet: Montag, 25. Juli 2016 03:19
An: AeroGear Developer Mailing List <aerogear-dev@lists.jboss.org>
Betreff: [aerogear-dev] Push message encryption to support PushMessageData of Push API


Hi all,


As we discussed previously, Firefox already supports sending push message data to browser if it will be encrypted. Since version 50, Google Chrome also support it [1]. But it requires for UPS to store "public key" and "auth secret" for each Installation [2]. See current example of sending push notifications with a payload[3].


Storing of two additional fields is not a big deal. But we also have to refactor PushNotificationSender [4], because it consumes a collection of device tokens as a param instead of a collection of installations.


Any thoughts about how we can implement it with minimal changes?


[1] https://developer.mozilla.org/en-US/docs/Web/API/PushMessageData

[2] https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/Installation.java

[3] https://serviceworke.rs/push-payload_index_doc.html

[4] https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/sender/src/main/java/org/jboss/aerogear/unifiedpush/message/sender/PushNotificationSender.java

Best regards,

Idel Pivnitskiy


GitHub: @idelpivnitskiy