Hi Erik!

this JIRA:
https://issues.jboss.org/browse/AGPUSH-629

and its PR (https://github.com/aerogear/aerogear-unifiedpush-server/pull/271) are related here, right ? 


On Wed, Jun 11, 2014 at 3:14 PM, Erik Jan de Wit <edewit@redhat.com> wrote:
Hi,

Right now the domain model of the UnifiedPush Server has the variants split into separate collections. 

https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/PushApplication.java#L44-L50

This could be improved to only use one collection, we’ll get more extendibility (adding another variant type for instance) and remove code like this:

https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/jpa/src/main/java/org/jboss/aerogear/unifiedpush/jpa/dao/impl/JPAPushApplicationDao.java#L93-L96

In places where you only want the iOS variants for instance you could either query them, or have a getter that collects them by type.

What do you think?

Cheers,
Erik Jan


_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf