On Tue, May 5, 2015 at 9:26 AM, Corinne Krych <corinnekrych@gmail.com> wrote:
Hello Sebi,


I've done an initial work on aerogear-ios-push [swift branch], adding a new parameter when doing the registration to pass the ag-push-id. See:

https://github.com/aerogear/aerogear-ios-push/compare/aerogear:master...corinnekrych:AGPUSH-1232.analytics.push.notification?expand=1

This client could be tested with HelloWorld. See:

https://github.com/jboss-mobile/unified-push-helloworld/compare/jboss-mobile:swift...corinnekrych:AGPUSH-1232.analytics.push.notification?expand=1

What is not covered is the background app coming to foreground through a push notification. If you look at HelloWorld:

https://github.com/jboss-mobile/unified-push-helloworld/blob/f7d0a7e093327f9a84041910c4c2892280c88ffb/ios-swift/HelloWorldSwift/AppDelegate.swift#L152

In iOS, when we go from background to foreground we don't go through registration API. The iOS push lib doesn't store locally (as opposed to windows sdk for ex) the device information. So i can't really make another call to registration API. What i'd suggest is to have a separate endpoint for metrics instead of having it coupled with registration endpoint. wdyt?


Ok, if that's needed, it has to be done! Thanks for the feedback and research here. But before we change, let's see how it behaves on Android
 

++

Corinne

On 4 May 2015 at 19:07, Sébastien Blanc <scm.blanc@gmail.com> wrote:
Hi Corinne !
We want to collect for both situations you described :)

Envoyé de mon iPhone

Le 4 mai 2015 à 17:53, Corinne Krych <corinnekrych@gmail.com> a écrit :

Hello Sebi,

After giving it a closer look, I've got a question for you: do we want to collect metrics only when an app is opened via push notification or do we also want to collect metrics when an app is brought to foreground by a push notification?

++
Corinne


On 4 May 2015 at 10:21, Corinne Krych <corinnekrych@gmail.com> wrote:
Yeap
on it.

On 30 April 2015 at 15:43, Sebastien Blanc <scm.blanc@gmail.com> wrote:
Hi,

The Advanced Analytics task[1] has a new PR[2] that has been rebased on the latest master and got a lot of polishing.

Could the Client Tech Leads take a look at it [3] and review ? The only "breaking" change is the rename of the header's name that identifies a Push Notification, it's called now "aerogear-push-id" 

Seb






_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev

_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--