Brain still in soccer stadium? ;-)
On Monday, October 8, 2012, Douglas Campos wrote:
On Oct 8, 2012, at 10:11 AM, Matthias Wessendorf wrote:
> thanks !
>
> did update, we now have (besides the type) these properties:
> - baseURL
> - loginEndpoint
> - logoutEndpoint
> - enroleEndpoint
English nit, enrollEndpoint?
>
> On Mon, Oct 8, 2012 at 3:05 PM, Kris Borchers <kris@redhat.com> wrote:
>>
>> On Oct 8, 2012, at 8:02 AM, Matthias Wessendorf <matzew@apache.org> wrote:
>>
>>> Quick update... I slightly changed the AuthModule protocol, by
>>> exposing two properties:
>>> - url (against where the auth module is mapped)
>>
>> Wouldn't you want to use baseURL and endpoint instead? That is what I have done for all of my rest adapters so far.
>>
>>> - type (e.g. REST etc)
>>>
>>> https://gist.github.com/3833333
>>>
>>> -M
>>>
>>> On Mon, Oct 8, 2012 at 2:49 PM, Matthias Wessendorf <matzew@apache.org> wrote:
>>>> any other comments ?
>>>>
>>>> -M
>>>>
>>>> On Sun, Oct 7, 2012 at 12:16 AM, Christos Vasilakis <cvasilak@gmail.com> wrote:
>>>>> Hi,
>>>>>
>>>>> For what is worth, I prefer the current approach with the two callbacks. Kind of more familiar with that pattern.
>>>>>
>>>>> Regards,
>>>>> Christos
>>>>>
>>>>> On 6 Ïêô 2012, at 1:51 ì.ì., Matthias Wessendorf <matzew@apache.org> wrote:
>>>>>
>>>>>> Hey,
>>>>>>
>>>>>> I tend to continue using two callbacks: One for 'success' and one for
>>>>>> the error case.
>>>>>>
>>>>>> Any objections?
>>>>>>
>>>>>> Greetings,
>>>>>> Matthias
>>>>>>
>>>>>> On Fri, Oct 5, 2012 at 9:26 AM, Matthias Wessendorf <matzew@apache.org> wrote:
>>>>>>> On Fri, Oct 5, 2012 at 9:09 AM, Elmar Kretzer <elkr@symentis.com> wrote:
>>>>>>>> Hi Matze, =)
>>>>>>>>
>>>>>>>> quite fast enroll of the first API version - congratulations.
>>>>>>>
>>>>>>> it's the third :)
>>>>>>> our Pipe API is already here:
>>>>>>> https://github.com/aerogear/aerogear-ios/blob/master/API.md
>>>>>>>
>>>>>>> The datamanager proposal is here:
>>>>>>> http://aerogear-dev.1069024.n5.nabble.com/aerogear-dev-iOS-DataManager-Storage-interface-tt300.html
>>>>>>>
>>>>>>>>
>>>>>>>> I just had a quick look at your gists - and i then i stumbled upon the
>>>>>>>> method with 2 blocks.
>>>>>>>>
>>>>>>>> It`s more like a personal flavor thing but sometimes methods with 2 block
>>>>>>>> params can look quite disturbing. So i tend to use up to 3 params if
>>>>>>>> necessary.
>>>>>>>
>>>>>>> I was following the pattern from the AFNetworking folks, since I used
>>>>>>> that underneath our 'http communication' facility;
>>>>>>> (see pipeline/pipe API)
>>>>>>>
>>>>>>>
>>>>>>> I think I generally don't mind one single block - but instead of
>>>>>>> completion, I'd prefer completionHandler :)
>>>>>>> Not sure...
>>>>>>>
>>>>>>>
>>>>>>>> I forked your gist for better explanation: https://gist.github.com/3838469-- qmx
_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev