On Tue, Oct 29, 2013 at 11:39 AM, Erik Jan de Wit <edewit@redhat.com> wrote:
Hi,

I saw that there was some discussion about whitespace in a javascript file on  a PR yesterday. Now it seems to me that among the things to discuss whitespace is just noise,

+1 - especially the amount of comments

 
especially because formatting can be done automatically.

Isn't it ? I did run 'grunt' on that PR and that tool was already crying about formating issues

 
Talking with qmx and lholmquist about this it seems that JS land doesn't have good tools for this. 


hrm - the grunt worked for me; but I don't know if it is _that_ good
 

To have something in the mean time we could use something like the eclipse formatter, because it can format JS has a ton of options and there are already a lot of external tools that use it:


I doubt that a JS weenie will use Eclipse/IDEA
 

similar w/ maven, adding maven to a JS build is a bit.... 
 

not sure about eclipse dependency;
 

So how about having something like this that will format our JS for us? We could integrate something like this in our build, or that or create our own CLI tool as long as we have something that will work so that we don't have to discuss formatting anymore, what do you think?

Again, not sure if something like grunt does already help us.

-M
 

Cheers,
Erik Jan

_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf