On Mon, Jun 17, 2013 at 9:50 PM, Kris Borchers <kris@redhat.com> wrote:

On Jun 17, 2013, at 2:47 PM, Lucas Holmquist <lholmqui@redhat.com> wrote:

i can agree with that.

I know where to get the socks-client.js and the vertxbus.js,   but where is the stomp.js file from

Well, it came from here https://github.com/hornetq/hornetq/blob/master/examples/jms/stomp-websockets/chat/stomp.js

After looking at that though, I have no idea where it came from.


Jeff's stomp.js is "located" here:
https://github.com/jmesnil/stomp-websocket/tree/master/dist
 
Is it a general STOMP JS impl, is it hornetq specific?

General. Used by:
* Apache ActiveMQ (+ Apollo)
* HornetMQ
* RabbitMQ
others

Remember: was used on the very first iteration of the "simple" SimplePush bits (the hacked HornetQ demo(

 
I have no idea. Also, the first comment in that file also troubles me … making me consider not doing a STOMP


Regardless of coffeescript or not, not sure if we really do need a "Stomp.js Adapter", right now... I guess, that a "stomp adapter" does make sense, when we really support "messaging" (e.g. JMS, AMQP or even MQTT on the backend). 


 
adapter but not sure if just the vert.x adapter is enough for now.


the vert.x eventbus "JS file" is backed by SockJS. It offers _similar_ functionality to stomp.js (at the end: all pub/sub)
 



to bad they all don't have bower stuff

On Jun 17, 2013, at 3:46 PM, Kris Borchers <kris@redhat.com> wrote:

After thinking about this for a bit, I think I would vote to not bundle those deps. I don't think there should be any errors thrown unless someone uses an interface that has one of those dependencies. If it does, that's an issue we need to fix. I think we need to spell out very clearly what is required to use those adapters and provide links.

On Jun 17, 2013, at 2:30 PM, Lucas Holmquist <lholmqui@redhat.com> wrote:

So AeroGear.js, the notifier stuff, has external dependencies on stomp.js / socks.js , depending on what adapter you use. ( probably also the vertxbus.js also )

The question is do we package these external dependencies with our JS libs or do we say "These are needed, so here are links to get them".

Using Bower, we can add the socks-client.js file,  but not the others.  

currently jQuery is a dependency, but we don't package that


THoughts?
_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf