On 15 Mar 2018 10:59, "Matthias Wessendorf" <mwessend@redhat.com> wrote:
I see you on the team -> https://hub.docker.com/u/darahayes/ (at least this account)On Thu, Mar 15, 2018 at 11:51 AM, Dara Hayes <dara.hayes@redhat.com> wrote:I 100% agree that it should be in the aerogear org and I suggested it at the time. However, we were never given access (even though we asked) :)On Thu, Mar 15, 2018 at 10:26 AM, Matthias Wessendorf <mwessend@redhat.com> wrote:The other question is ... is "aerogearcatalog" the right choice ?IMO no - since that https://github.com/aerogear/grafana-docker is not an APBIMO it would be better in "aerogear" dh org ;-)--On Thu, Mar 15, 2018 at 11:25 AM, Matthias Wessendorf <mwessend@redhat.com> wrote:there is no issue w/ forks etc :-)I just found it very annoying not seeing any hint on the repo, in dockerhub :-)I will update it--On Thu, Mar 15, 2018 at 11:19 AM, Dara Hayes <dara.hayes@redhat.com> wrote:TL;DR: We forked the grafana build tools [0] and built a commit off the master branch that we knew to be stable. In addition we modified the build scripts to include some Grafana plugins inside the container image. There were two reasons we did this.1. We were depending on new features in Grafana that were only available on the master branch. Grafana was under very heavy development as they geared up towards their 5.0 release and we were finding new problems arising every few days while we worked off the master branch. This was really slowing down APB development.2. We needed to install additional plugins required by some dashboards. Grafana's docker image provides a way to install plugins using environment variables fed into the container at runtime but this requires root access which is not feasible in Openshift. The only way we could do it at the time was by baking in the plugins as part of the docker build. It's a terrible solution but it was the only way at the time to continue the very fast pace of development of the APBs.There are still a some questions to be answered:* How are we going to distribute Grafana on OpenShift such that it doesn't require root access?* What is the best way to install plugins? There was some discussion about the different options and the consequences of those options in this document [1]This all arose during a sprint where one of the primary goals was to deliver an APB that could provision Grafana + Prometheus and display dashboard discovery and some other features. We decided at the time that we were not prepared to answer those bigger questions so we knowingly put this technical debt on ourselves and implemented a quick and dirty solution.This entire thing was discussed publicly in a Github PR: https://github.com/aerogearcatalog/keycloak-apb/pull/33 But perhaps it should also have been mentioned on list at the time. Hope this clears things up.--On Thu, Mar 15, 2018 at 9:27 AM, David Martin <davmarti@redhat.com> wrote:I remember a rember there's a reason for having a custom image built
(we need specific features that aren't in latest upstream image), but
I'm not sure who pushed it up and from where.
@Dara @Steven, is there a fork of grafana or some repo where we have
the Dockerfile?
--
On 14 March 2018 at 15:15, Matthias Wessendorf <matzew@apache.org> wrote:
> Hi,
>
> I am not able to find the image for this container:
> https://hub.docker.com/r/aerogearcatalog/grafana/
>
> If not an automated build repo, we should at least point to the actual
> aerogear GH repository, where the thing is located.
>
> Thanks
>
> --
> Matthias Wessendorf
>
> github: https://github.com/matzew
> twitter: http://twitter.com/mwessendorf
>
> --
> You received this message because you are subscribed to the Google Groups
> "Aerogear" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to aerogear+unsubscribe@googlegroups.com .
> To post to this group, send email to aerogear@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/aerogear/CAAg5f2RgsYFDWqG% .3DX%3Dj%3D48fVhCH2nrgjRuXNdNF9 za3nt8uhSQ%40mail.gmail.com
> For more options, visit https://groups.google.com/d/optout .
David Martin
Red Hat Mobile
Twitter: @irldavem
IRC: @irldavem (#aerogear)
--
You received this message because you are subscribed to the Google Groups "Aerogear" group.
To unsubscribe from this group and stop receiving emails from it, send an email to aerogear+unsubscribe@googlegroups.com .
To post to this group, send email to aerogear@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/aerogear/CABkcJC19HDKXS2jT .UMj%2BU8Z8e27o4uD55Rea%2B7Eu8K SfBY4nrg%40mail.gmail.com Project lead AeroGear.orgProject lead AeroGear.org----Project lead AeroGear.org
