+1 on not having separate table per variant type and using different
inheritance model here - for instance a discriminator column.

Karel

On Wed, 11 Jun 2014 15:14:21 +0200
Erik Jan de Wit <edewit@redhat.com> wrote:

> Hi,
>
> Right now the domain model of the UnifiedPush Server has the variants split
> into separate collections.
>
> https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/PushApplication.java#L44-L50
>
> This could be improved to only use one collection, we’ll get more
> extendibility (adding another variant type for instance) and remove code like
> this:
>
> https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/jpa/src/main/java/org/jboss/aerogear/unifiedpush/jpa/dao/impl/JPAPushApplicationDao.java#L93-L96
>
> In places where you only want the iOS variants for instance you could either
> query them, or have a getter that collects them by type.
>
> What do you think?
>
>       Cheers,
>               Erik Jan
>

_______________________________________________
aerogear-dev mailing list
aerogear-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev