3:19 p.m.
I just committed some guides for using the Aerogear Android libraries.
https://github.com/aerogear/aerogear.org/commit/d3cae265d
I'm still editing them for gramma/spelling/formatting, so be warned
(hence why I havn't PRed it yet). Also, if there is anything I missed,
glossed over, explained like crap let me know and I will try to reword
it when I begin proofreading.
Summers
3:44 a.m.
Howdy,
great to see some docs/guides
Here are my first/initial comments:
1) Group them into a subfolder, like daniel did, for the controller
2) links to the matching JavaDocs (classes (e.g. PipeHandlert etc)) does
not hurt
3) not sure about if the `AerogearAndroidCustomizingPipes.asciidoc` is
really useful ...
"AerogearAndroidPagination"
4) You never show ParameterProvider...
5) what is config.setDataRoot()
--> looks like the Android bits are a bit _different_, compared to the
iOS/JS version
6) do I really have to implement my own "PageResultExtractor"
The Pagination feels: Lot's of code... for a simple read...
-Matthias
On Tue, Mar 19, 2013 at 9:19 PM, Summers Pittman <supittma(a)redhat.com>wrote:
I just committed some guides for using the Aerogear Android
libraries.
https://github.com/aerogear/aerogear.org/commit/d3cae265d
I'm still editing them for gramma/spelling/formatting, so be warned (hence
why I havn't PRed it yet). Also, if there is anything I missed, glossed
over, explained like crap let me know and I will try to reword it when I
begin proofreading.
Summers
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
8:01 a.m.
nice guides!
some small comments:
In AerogearAndroidPipes101.asciidoc
- Android’s Loader API --> a link to the official android doc:
http://developer.android.com/guide/components/loaders.html
- On the paragraph describing the Loader API I think it's good to append the added
benefit AeroGear provides to the loader API e.g.
"AeroGear transparently handles the registration and attaching of the callback in the
Loader mechanism, without the user having to explicitly declare it"…or sth similar.
---
In AerogearAndroidPagination.asciidoc
- new PageConsumer()) ? -> did you mean "new SamplePageResultExtractor()"
- typos and comma: ...special requirements or legacy services, AeroGear's pagination
framework can be easily extended to support them.
---
In AerogearAndroidDataStore.asciidoc
- Creating a Memory Store
.....Also it can not perform nested querying of its data. -> Note that currently, it
doesn't support nested querying of its data.
- Creating a SQLStore
not sure if nested querying is supported,
if it does -> Unlike MemoryStore, the SQLStore supports nested query of its
data.
if not -> Similar to MemoryStore, the SQLStore doesn't support nested query
of its data.
- typo: can conly filter -> can only filter
In AerogearAndroidAuthentication.asciidoc
- typo: encapuslates -> encapsulates, instanciate -> instantiate
In AerogearAndroidCustomizingPipes.asciidoc
- ...managing PipeHandler instances and returning their results and returning them to the
user via callbacks.. ->
...managing PipeHandler instances, processing their results and returning them to the
user via callbacks..
- thustly?
Thanks
Christos
On Mar 20, 2013, at 10:44 AM, Matthias Wessendorf <matzew(a)apache.org> wrote:
Howdy,
great to see some docs/guides
Here are my first/initial comments:
1) Group them into a subfolder, like daniel did, for the controller
2) links to the matching JavaDocs (classes (e.g. PipeHandlert etc)) does not hurt
3) not sure about if the `AerogearAndroidCustomizingPipes.asciidoc` is really useful ...
"AerogearAndroidPagination"
4) You never show ParameterProvider...
5) what is config.setDataRoot()
--> looks like the Android bits are a bit _different_, compared to the iOS/JS version
6) do I really have to implement my own "PageResultExtractor"
The Pagination feels: Lot's of code... for a simple read...
-Matthias
On Tue, Mar 19, 2013 at 9:19 PM, Summers Pittman <supittma(a)redhat.com> wrote:
I just committed some guides for using the Aerogear Android libraries.
https://github.com/aerogear/aerogear.org/commit/d3cae265d
I'm still editing them for gramma/spelling/formatting, so be warned (hence why I
havn't PRed it yet). Also, if there is anything I missed, glossed over, explained
like crap let me know and I will try to reword it when I begin proofreading.
Summers
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
1:57 p.m.
On 03/20/2013 04:44 AM, Matthias Wessendorf wrote:
Howdy,
great to see some docs/guides
Here are my first/initial comments:
1) Group them into a subfolder, like daniel did, for the controller
+1
2) links to the matching JavaDocs (classes (e.g. PipeHandlert etc))
does not hurt
+1
3) not sure about if the `AerogearAndroidCustomizingPipes.asciidoc` is
really useful ...
I disagree. It may be titled wrong, but knowing how the Android
library
implements Pipes and how to extend this implementations for your own end
is quite useful.
At least that is the goal of the doc, what did you see differently?
"AerogearAndroidPagination"
4) You never show ParameterProvider...
Because the default implementation of
Parameter Provider just consumes
data provided by the PageConsumer. Explicitly setting it isn't necessary.
5) what is config.setDataRoot()
The root of the data you want
to operate on as explained in the Intro
document and the API's.
For example, in the DevNexus result set for speakers you have
{
speakers : {
data:[
{speaker1},
{speaker2}
]
}
}
The "list" of data you are asking for actually starts at the data
parameter of the speakers parameter.
config.setDataRoot("speakers.data"); makes this explicit.
--> looks like the Android bits are a bit _different_, compared to
the
iOS/JS version
6) do I really have to implement my own "PageResultExtractor"
No unless
you are consuming it from a service where the paging doesn't
follow "simple" patterns.
The Pagination feels: Lot's of code... for a simple read...
Because the simple read of pagination is linked to at the beginning for
the doc. This is for consuming arbitrary paging from a site. Perhaps
this needs to be an "advanced" doc and I should discuss simpler paging
in an into doc. Like Pipes.
-Matthias
Seems like some of the docs might be missing things (an intro read to
paging, more explicit goals of the guid etc).
On Tue, Mar 19, 2013 at 9:19 PM, Summers Pittman <supittma(a)redhat.com
<mailto:supittma@redhat.com>> wrote:
I just committed some guides for using the Aerogear Android
libraries.
https://github.com/aerogear/aerogear.org/commit/d3cae265d
I'm still editing them for gramma/spelling/formatting, so be
warned (hence why I havn't PRed it yet). Also, if there is
anything I missed, glossed over, explained like crap let me know
and I will try to reword it when I begin proofreading.
Summers
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2:02 p.m.
On 03/20/2013 09:01 AM, Christos Vasilakis wrote:
nice guides!
some small comments:
In *AerogearAndroidPipes101.asciidoc*
- Android's Loader API --> a link to the official android doc:
http://developer.android.com/guide/components/loaders.html
- On the paragraph describing the Loader API I think it's good to
append the added benefit AeroGear provides to the loader API e.g.
"AeroGear transparently handles the registration and attaching of the
callback in the Loader mechanism, without the user having to
explicitly declare it"...or sth similar.
---
In *AerogearAndroidPagination.asciidoc*
- new PageConsumer()) ? -> did you mean "new SamplePageResultExtractor()"
I did. Good catch.
- typos and comma: ...special requirements or legacy services,
AeroGear's pagination framework can be easily extended to support them.
Yeah I
havn't proofread for grammr/spelling/etc yet.
---
In *AerogearAndroidDataStore.asciidoc*
- Creating a Memory Store
.....Also it can not perform nested querying of its data. *->* Note
that currently, it doesn't support nested querying of its data.
- Creating a SQLStore
not sure if nested querying is supported,
*if it does* -> Unlike MemoryStore, the SQLStore supports nested query
of its data.
*if not* -> Similar to MemoryStore, the SQLStore doesn't support
nested query of its data.
- typo: can conly filter -> can only filter
Yeah, maybe I should drop the talk
of flitering all together since it
was removed from the spec.
In *AerogearAndroidAuthentication.asciidoc*
*
*
- typo: encapuslates -> encapsulates, instanciate -> instantiate
Thanks
In *AerogearAndroidCustomizingPipes.asciidoc*
*
*
- ...managing PipeHandler instances and returning their results
and returning them to the user via callbacks.. *-> *
...managing PipeHandler instances, processing their results
and returning them to the user via callbacks..
- thustly?
Typo, should be thusly. (it means the next blob of stuff is an example
of what I am talking about or the conclusions to be drawn from what I
was just saying). Probably not a particularly common word.
Thanks
Christos
On Mar 20, 2013, at 10:44 AM, Matthias Wessendorf <matzew(a)apache.org
<mailto:matzew@apache.org>> wrote:
> Howdy,
>
> great to see some docs/guides
>
> Here are my first/initial comments:
>
> 1) Group them into a subfolder, like daniel did, for the controller
>
> 2) links to the matching JavaDocs (classes (e.g. PipeHandlert etc))
> does not hurt
>
> 3) not sure about if the `AerogearAndroidCustomizingPipes.asciidoc`
> is really useful ...
>
> "AerogearAndroidPagination"
> 4) You never show ParameterProvider...
> 5) what is config.setDataRoot()
> --> looks like the Android bits are a bit _different_, compared to
> the iOS/JS version
> 6) do I really have to implement my own "PageResultExtractor"
>
> The Pagination feels: Lot's of code... for a simple read...
>
>
>
> -Matthias
>
>
> On Tue, Mar 19, 2013 at 9:19 PM, Summers Pittman <supittma(a)redhat.com
> <mailto:supittma@redhat.com>> wrote:
>
> I just committed some guides for using the Aerogear Android
> libraries.
>
> https://github.com/aerogear/aerogear.org/commit/d3cae265d
>
>
> I'm still editing them for gramma/spelling/formatting, so be
> warned (hence why I havn't PRed it yet). Also, if there is
> anything I missed, glossed over, explained like crap let me know
> and I will try to reword it when I begin proofreading.
>
> Summers
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2:15 p.m.
On Thu, Mar 21, 2013 at 7:57 PM, Summers Pittman <supittma(a)redhat.com>wrote:
On 03/20/2013 04:44 AM, Matthias Wessendorf wrote:
Howdy,
great to see some docs/guides
Here are my first/initial comments:
1) Group them into a subfolder, like daniel did, for the controller
+1
2) links to the matching JavaDocs (classes (e.g. PipeHandlert etc)) does
not hurt
+1
3) not sure about if the `AerogearAndroidCustomizingPipes.asciidoc` is
really useful ...
I disagree. It may be titled wrong, but knowing how the Android library
implements Pipes and how to extend this implementations for your own end is
quite useful.
At least that is the goal of the doc, what did you see differently?
"AerogearAndroidPagination"
4) You never show ParameterProvider...
Because the default implementation of Parameter Provider just consumes
data provided by the PageConsumer. Explicitly setting it isn't necessary.
5) what is config.setDataRoot()
The root of the data you want to operate on as explained in the Intro
document and the API's.
For example, in the DevNexus result set for speakers you have
{
speakers : {
data:[
{speaker1},
{speaker2}
]
}
}
The "list" of data you are asking for actually starts at the data
parameter of the speakers parameter. config.setDataRoot("speakers.data");
makes this explicit.
Hrm - interesting. I think that would be nice thing, generally;
I guess a bit more open discussions on "features" like that would be good.
(thinks: API/SPEC discussions)
Currently, I do not see why this would not be benefit for the JS or iOS
library. A heads up would have been a good idea, IMO
Or... perhaps I just missed it
--> looks like the Android bits are a bit _different_, compared to the
iOS/JS version
6) do I really have to implement my own "PageResultExtractor"
No unless you are consuming it from a service where the paging doesn't
follow "simple" patterns.
The Pagination feels: Lot's of code... for a simple read...
Because the simple read of pagination is linked to at the beginning for
the doc. This is for consuming arbitrary paging from a site. Perhaps this
needs to be an "advanced" doc and I should discuss simpler paging in an
into doc. Like Pipes.
-Matthias
Seems like some of the docs might be missing things (an intro read to
paging, more explicit goals of the guid etc).
On Tue, Mar 19, 2013 at 9:19 PM, Summers Pittman <supittma(a)redhat.com>wrote:
> I just committed some guides for using the Aerogear Android libraries.
>
> https://github.com/aerogear/aerogear.org/commit/d3cae265d
>
>
> I'm still editing them for gramma/spelling/formatting, so be warned
> (hence why I havn't PRed it yet). Also, if there is anything I missed,
> glossed over, explained like crap let me know and I will try to reword it
> when I begin proofreading.
>
> Summers
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing
listaerogear-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
2:50 p.m.
I think I don't really understand "SamplePageResultExtractor"
how/where it's used
On Tue, Mar 19, 2013 at 9:19 PM, Summers Pittman <supittma(a)redhat.com>wrote:
I just committed some guides for using the Aerogear Android
libraries.
https://github.com/aerogear/aerogear.org/commit/d3cae265d
I'm still editing them for gramma/spelling/formatting, so be warned (hence
why I havn't PRed it yet). Also, if there is anything I missed, glossed
over, explained like crap let me know and I will try to reword it when I
begin proofreading.
Summers
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
2:55 p.m.
On 03/21/2013 03:50 PM, Matthias Wessendorf wrote:
I think I don't really understand
"SamplePageResultExtractor"
Ahhh yes. The document is bad at explaining
that.
By default/the spec the Pagination support assumes that the
next/previous identifiers point to URI's relative to the baseURL of the
Pipe.
If this is not the case then you have to write a PageResultExtractor.
how/where it's used
On Tue, Mar 19, 2013 at 9:19 PM, Summers Pittman <supittma(a)redhat.com
<mailto:supittma@redhat.com>> wrote:
I just committed some guides for using the Aerogear Android
libraries.
https://github.com/aerogear/aerogear.org/commit/d3cae265d
I'm still editing them for gramma/spelling/formatting, so be
warned (hence why I havn't PRed it yet). Also, if there is
anything I missed, glossed over, explained like crap let me know
and I will try to reword it when I begin proofreading.
Summers
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2:56 p.m.
I'm working on putting links to apis
On Thu, Mar 21, 2013 at 4:50 PM, Matthias Wessendorf <matzew(a)apache.org>wrote:
I think I don't really understand
"SamplePageResultExtractor"
how/where it's used
On Tue, Mar 19, 2013 at 9:19 PM, Summers Pittman <supittma(a)redhat.com>wrote:
> I just committed some guides for using the Aerogear Android libraries.
>
> https://github.com/aerogear/aerogear.org/commit/d3cae265d
>
>
> I'm still editing them for gramma/spelling/formatting, so be warned
> (hence why I havn't PRed it yet). Also, if there is anything I missed,
> glossed over, explained like crap let me know and I will try to reword it
> when I begin proofreading.
>
> Summers
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
2:57 p.m.
On 03/21/2013 03:56 PM, Daniel Passos wrote:
I'm working on putting links to apis
Thanks! Right now I
am running through and tidying things up (spelling,
grammar, fixing the paging doc)
On Thu, Mar 21, 2013 at 4:50 PM, Matthias Wessendorf
<matzew(a)apache.org <mailto:matzew@apache.org>> wrote:
I think I don't really understand "SamplePageResultExtractor"
how/where it's used
On Tue, Mar 19, 2013 at 9:19 PM, Summers Pittman
<supittma(a)redhat.com <mailto:supittma@redhat.com>> wrote:
I just committed some guides for using the Aerogear Android
libraries.
https://github.com/aerogear/aerogear.org/commit/d3cae265d
I'm still editing them for gramma/spelling/formatting, so be
warned (hence why I havn't PRed it yet). Also, if there is
anything I missed, glossed over, explained like crap let me
know and I will try to reword it when I begin proofreading.
Summers
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/aerogear-dev
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev
4051
days inactive
4053
days old
9 comments
4 participants
participants (4)
-
Christos Vasilakis -
Daniel Passos -
Matthias Wessendorf -
Summers Pittman