On Oct 24, 2014, at 10:16 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: On Fri, Oct 24, 2014 at 3:36 PM, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: Hello, So i’ve decided to take today and try and add Safari Push notifications into the UPS. When i tried about a year ago, i was successful, but i had lots of duplicated code since it is very close to the iOS variant. basically, the only real difference is that Safari notifications use the Production cert only. The other slight difference is how you send the message to the APNs service I wondering if now is the time to start changing the variant names, so iOSVariant would become APNsVariant(or something like that). +1 This would also change the endpoint at which we connect from ‘ios' to ‘apns’ . Since this is sort of a breaking change, from a curl perspective, does this need to wait until a Major release? Let's have it for master (1.1.x series) only. That said, since there may be a few mire 1.0.x releases, which also may have effect to the 1.1.x code base (merges), I'd like to wait a bit with the actual merge of "Safari push" to master. plus this might make the current db migration stuff that is in progress more complex too I have no problems keeping it separate, and then in a later release merging things together ah, yeah - that's the best :) no need to "wait" on the work, let's keep branch in sync w/ master, and merge in a few weeks... ok ?

-Matthias wdyt? -Luke _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________... aerogear-dev mailing list aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev>

On Oct 24, 2014, at 10:16 AM, Matthias Wessendorf <matzew(a)apache.org <javascript:_e(%7B%7D,'cvml','matzew@apache.org');>> wrote: On Fri, Oct 24, 2014 at 3:36 PM, Lucas Holmquist <lholmqui(a)redhat.com <javascript:_e(%7B%7D,'cvml','lholmqui@redhat.com');>> wrote: > Hello, > > So i’ve decided to take today and try and add Safari Push notifications > into the UPS. When i tried about a year ago, i was successful, but i had > lots of duplicated code since it is very close to the iOS variant. > basically, the only real difference is that Safari notifications use the > Production cert only. The other slight difference is how you send the > message to the APNs service > > I wondering if now is the time to start changing the variant names, so > iOSVariant would become APNsVariant(or something like that). > this would also apply to Android and Chrome since now both use the same GCM,

+1 > > This would also change the endpoint at which we connect from ‘ios' to > ‘apns’ . Since this is sort of a breaking change, from a curl > perspective, does this need to wait until a Major release? > Let's have it for master (1.1.x series) only. That said, since there may be a few mire 1.0.x releases, which also may have effect to the 1.1.x code base (merges), I'd like to wait a bit with the actual merge of "Safari push" to master. > > plus this might make the current db migration stuff that is in progress > more complex too > > I have no problems keeping it separate, and then in a later release > merging things together > ah, yeah - that's the best :) no need to "wait" on the work, let's keep branch in sync w/ master, and merge in a few weeks... ok ? -Matthias > wdyt? > > -Luke > > > > > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > <javascript:_e(%7B%7D,'cvml','aerogear-dev@lists.jboss.org');> > https://lists.jboss.org/mailman/listinfo/aerogear-dev -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org <javascript:_e(%7B%7D,'cvml','aerogear-dev@lists.jboss.org');> https://lists.jboss.org/mailman/listinfo/aerogear-dev

So i’ve run into a bit of a problem, I’m trying to send notifications, using https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... but i’m not sure how to also tell it to use the new SafarVariant.class that i’ve created.

On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <edewit(a)redhat.com&gt; wrote: On 27 Oct,2014, at 14:15 , Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: So i’ve run into a bit of a problem, I’m trying to send notifications, using https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... but i’m not sure how to also tell it to use the new SafarVariant.class that i’ve created. Right now a sender is configured to send notifications for one specific variant type, this mapping is configured on the top of the class: https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... so APNsPushNotificationSender will only be use for iOSVariant variants, so either we change the way this works or you create a new Sender ( that extends this one maybe ) I think i’ll just create a new sender of now just to get something working since the SafariVariant and iOSVariant will be combined into an APNsVariant in the near future.

Cheers, Erik Jan _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Oct 28, 2014, at 3:21 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: Here is the initial addition in one of my branches: https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push <https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-pu... > On Oct 27, 2014, at 9:42 AM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: > > > > On Mon, Oct 27, 2014 at 2:28 PM, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: > >> On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <edewit(a)redhat.com <mailto:edewit@redhat.com>> wrote: >> >> On 27 Oct,2014, at 14:15 , Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: >> >>> >>> So i’ve run into a bit of a problem, I’m trying to send notifications, using https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... <https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>> >>> but i’m not sure how to also tell it to use the new SafarVariant.class that i’ve created. >> >> Right now a sender is configured to send notifications for one specific variant type, this mapping is configured on the top of the class: >> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... <https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >> >> so APNsPushNotificationSender will only be use for iOSVariant variants, so either we change the way this works or you create a new Sender ( that extends this one maybe ) > > I think i’ll just create a new sender of now just to get something working since the SafariVariant and iOSVariant will be combined into an APNsVariant in the near future. > > sounds reasonable on getting this started > > -M > > > >> >> Cheers, >> Erik Jan >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> > sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> > twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________... > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

i’ve created a safari-push branch on my fork of the open shift cartridge, https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wi... i’ve been trying to create an app with it but haven’t been successful, perhaps something i’m doing, anyone mind giving it a try On Oct 28, 2014, at 3:35 PM, Lucas Holmquist <lholmqui(a)redhat.com <javascript:_e(%7B%7D,'cvml','lholmqui@redhat.com');>> wrote: The branch on the main repo https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push subsequent PR’s will target this one On Oct 28, 2014, at 3:21 PM, Lucas Holmquist <lholmqui(a)redhat.com <javascript:_e(%7B%7D,'cvml','lholmqui@redhat.com');>> wrote: Here is the initial addition in one of my branches: https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push On Oct 27, 2014, at 9:42 AM, Matthias Wessendorf <matzew(a)apache.org <javascript:_e(%7B%7D,'cvml','matzew@apache.org');>> wrote: On Mon, Oct 27, 2014 at 2:28 PM, Lucas Holmquist <lholmqui(a)redhat.com <javascript:_e(%7B%7D,'cvml','lholmqui@redhat.com');>> wrote: > > On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <edewit(a)redhat.com > <javascript:_e(%7B%7D,'cvml','edewit@redhat.com');>> wrote: > > On 27 Oct,2014, at 14:15 , Lucas Holmquist <lholmqui(a)redhat.com > <javascript:_e(%7B%7D,'cvml','lholmqui@redhat.com');>> wrote: > > > So i’ve run into a bit of a problem, I’m trying to send notifications, > using > https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... > > but i’m not sure how to also tell it to use the new SafarVariant.class > that i’ve created. > > > Right now a sender is configured to send notifications for one specific > variant type, this mapping is configured on the top of the class: > > https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... > > so APNsPushNotificationSender will only be use for iOSVariant variants, > so either we change the way this works or you create a new Sender ( that > extends this one maybe ) > > > I think i’ll just create a new sender of now just to get something > working since the SafariVariant and iOSVariant will be combined into an > APNsVariant in the near future. > sounds reasonable on getting this started -M > > > > > Cheers, > Erik Jan > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > <javascript:_e(%7B%7D,'cvml','aerogear-dev@lists.jboss.org');> > https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > <javascript:_e(%7B%7D,'cvml','aerogear-dev@lists.jboss.org');> > https://lists.jboss.org/mailman/listinfo/aerogear-dev > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org <javascript:_e(%7B%7D,'cvml','aerogear-dev@lists.jboss.org');> https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org <javascript:_e(%7B%7D,'cvml','aerogear-dev@lists.jboss.org');> https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org <javascript:_e(%7B%7D,'cvml','aerogear-dev@lists.jboss.org');> https://lists.jboss.org/mailman/listinfo/aerogear-dev

Here is what I did, on command line: rhc app create --no-git safari " https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/open... " One the console, I am getting: Creating application 'safari' ... Server returned an unexpected error code: 504 but.... well, here is the server -> https://safari-pushee.rhcloud.com/ag-push What I do not understand it the 504 :) On Wed, Oct 29, 2014 at 10:01 PM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: > any log from rhc client? > > > On Wednesday, October 29, 2014, Lucas Holmquist <lholmqui(a)redhat.com&gt; > wrote: > >> i’ve created a safari-push branch on my fork of the open shift >> cartridge, >> >> >> https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wi... >> >> >> i’ve been trying to create an app with it but haven’t been successful, >> perhaps something i’m doing, anyone mind giving it a try >> >> On Oct 28, 2014, at 3:35 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; >> wrote: >> >> >> The branch on the main repo >> https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push >> >> subsequent PR’s will target this one >> >> On Oct 28, 2014, at 3:21 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; >> wrote: >> >> Here is the initial addition in one of my branches: >> https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push >> >> On Oct 27, 2014, at 9:42 AM, Matthias Wessendorf <matzew(a)apache.org&gt; >> wrote: >> >> >> >> On Mon, Oct 27, 2014 at 2:28 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; >> wrote: >> >>> >>> On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <edewit(a)redhat.com&gt; wrote: >>> >>> On 27 Oct,2014, at 14:15 , Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: >>> >>> >>> So i’ve run into a bit of a problem, I’m trying to send notifications, >>> using >>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>> >>> but i’m not sure how to also tell it to use the new SafarVariant.class >>> that i’ve created. >>> >>> >>> Right now a sender is configured to send notifications for one specific >>> variant type, this mapping is configured on the top of the class: >>> >>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>> >>> so APNsPushNotificationSender will only be use for iOSVariant variants, >>> so either we change the way this works or you create a new Sender ( that >>> extends this one maybe ) >>> >>> >>> I think i’ll just create a new sender of now just to get something >>> working since the SafariVariant and iOSVariant will be combined into an >>> APNsVariant in the near future. >>> >> >> sounds reasonable on getting this started >> >> -M >> >>> >>> >>> >>> >>> Cheers, >>> Erik Jan >>> >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> >>> >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>> >> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> > > -- > Sent from Gmail Mobile > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf

On Oct 30, 2014, at 2:57 AM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: I tried the same, again with -d (rhc -d), that worked fine.... hrm... On Thu, Oct 30, 2014 at 7:48 AM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: hahaha, than it disappeared ??? :-) looks like the 'delete' was triggered by the 504 ? On Thu, Oct 30, 2014 at 7:47 AM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: Here is what I did, on command line: rhc app create --no-git safari "https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/openshift-origin-cartridge-aerogear-push-wildfly&commit=086fe4f75f8991e7780c9df078c7371377c68aa2 <https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/open... One the console, I am getting: Creating application 'safari' ... Server returned an unexpected error code: 504 but.... well, here is the server -> https://safari-pushee.rhcloud.com/ag-push <https://safari-pushee.rhcloud.com/ag-push> What I do not understand it the 504 :) On Wed, Oct 29, 2014 at 10:01 PM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: any log from rhc client? On Wednesday, October 29, 2014, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: i’ve created a safari-push branch on my fork of the open shift cartridge, https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wi... <https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wi... i’ve been trying to create an app with it but haven’t been successful, perhaps something i’m doing, anyone mind giving it a try > On Oct 28, 2014, at 3:35 PM, Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: > > > The branch on the main repo https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push <https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push> > > subsequent PR’s will target this one > >> On Oct 28, 2014, at 3:21 PM, Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >> >> Here is the initial addition in one of my branches: https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push <https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-pu... >>> On Oct 27, 2014, at 9:42 AM, Matthias Wessendorf <matzew(a)apache.org <>> wrote: >>> >>> >>> >>> On Mon, Oct 27, 2014 at 2:28 PM, Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >>> >>>> On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <edewit(a)redhat.com <>> wrote: >>>> >>>> On 27 Oct,2014, at 14:15 , Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >>>> >>>>> >>>>> So i’ve run into a bit of a problem, I’m trying to send notifications, using https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... <https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>>>> >>>>> but i’m not sure how to also tell it to use the new SafarVariant.class that i’ve created. >>>> >>>> Right now a sender is configured to send notifications for one specific variant type, this mapping is configured on the top of the class: >>>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... <https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>>> >>>> so APNsPushNotificationSender will only be use for iOSVariant variants, so either we change the way this works or you create a new Sender ( that extends this one maybe ) >>> >>> I think i’ll just create a new sender of now just to get something working since the SafariVariant and iOSVariant will be combined into an APNsVariant in the near future. >>> >>> sounds reasonable on getting this started >>> >>> -M >>> >>> >>> >>>> >>>> Cheers, >>>> Erik Jan >>>> >>>> >>>> _______________________________________________ >>>> aerogear-dev mailing list >>>> aerogear-dev(a)lists.jboss.org <> >>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org <> >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>> >>> >>> >>> -- >>> Matthias Wessendorf >>> >>> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> >>> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> >>> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________... >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org <> >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org <> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org <> > https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> -- Sent from Gmail Mobile -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf> -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf> -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________... aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Nov 5, 2014, at 2:03 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: so i wrote a little blog post on this, http://blog.lholmquist.org/safari-push-notifications/ <http://blog.lholmquist.org/safari-push-notifications/> So i’ve made the iOSVariant an APNsVariant, but now i have a decision. currently on the safari-push branch, https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push <https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push>;, i’ve changed the UI to this: http://blog.lholmquist.org/content/images/2014/Nov/Screen_Shot_2014_11_05... <http://blog.lholmquist.org/content/images/2014/Nov/Screen_Shot_2014_11_05... where there is 1 variant to choose from for iOS and Safari. And not really and way to tell the difference if a variant is for safari or for iOS I’m wondering if there should be 2 selections that hit the same(update from ios) “apns" endpoint, and also a field on the APNsVariant to differentiate between iOS and Safari, i can see this as being something for analytics

If we agree to go this route, then we can do the same when we update the GCMVariant > On Oct 30, 2014, at 9:13 AM, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: > > hmm, indeed, let me try that also >> On Oct 30, 2014, at 2:57 AM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: >> >> I tried the same, again with -d (rhc -d), that worked fine.... >> >> >> hrm... >> >> On Thu, Oct 30, 2014 at 7:48 AM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: >> hahaha, than it disappeared ??? :-) >> >> looks like the 'delete' was triggered by the 504 ? >> >> On Thu, Oct 30, 2014 at 7:47 AM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: >> Here is what I did, on command line: >> rhc app create --no-git safari "https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/openshift-origin-cartridge-aerogear-push-wildfly&commit=086fe4f75f8991e7780c9df078c7371377c68aa2 <https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/open... >> >> >> >> One the console, I am getting: >> Creating application 'safari' ... Server returned an unexpected error code: 504 >> >> >> >> >> but.... well, here is the server -> https://safari-pushee.rhcloud.com/ag-push <https://safari-pushee.rhcloud.com/ag-push> >> >> >> >> What I do not understand it the 504 :) >> >> >> >> >> >> On Wed, Oct 29, 2014 at 10:01 PM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: >> any log from rhc client? >> >> >> On Wednesday, October 29, 2014, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: >> i’ve created a safari-push branch on my fork of the open shift cartridge, >> >> https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wi... <https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wi... >> >> >> i’ve been trying to create an app with it but haven’t been successful, perhaps something i’m doing, anyone mind giving it a try >>> On Oct 28, 2014, at 3:35 PM, Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >>> >>> >>> The branch on the main repo https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push <https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push> >>> >>> subsequent PR’s will target this one >>> >>>> On Oct 28, 2014, at 3:21 PM, Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >>>> >>>> Here is the initial addition in one of my branches: https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push <https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-pu... >>>>> On Oct 27, 2014, at 9:42 AM, Matthias Wessendorf <matzew(a)apache.org <>> wrote: >>>>> >>>>> >>>>> >>>>> On Mon, Oct 27, 2014 at 2:28 PM, Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >>>>> >>>>>> On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <edewit(a)redhat.com <>> wrote: >>>>>> >>>>>> On 27 Oct,2014, at 14:15 , Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >>>>>> >>>>>>> >>>>>>> So i’ve run into a bit of a problem, I’m trying to send notifications, using https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... <https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>>>>>> >>>>>>> but i’m not sure how to also tell it to use the new SafarVariant.class that i’ve created. >>>>>> >>>>>> Right now a sender is configured to send notifications for one specific variant type, this mapping is configured on the top of the class: >>>>>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... <https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>>>>> >>>>>> so APNsPushNotificationSender will only be use for iOSVariant variants, so either we change the way this works or you create a new Sender ( that extends this one maybe ) >>>>> >>>>> I think i’ll just create a new sender of now just to get something working since the SafariVariant and iOSVariant will be combined into an APNsVariant in the near future. >>>>> >>>>> sounds reasonable on getting this started >>>>> >>>>> -M >>>>> >>>>> >>>>> >>>>>> >>>>>> Cheers, >>>>>> Erik Jan >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> aerogear-dev mailing list >>>>>> aerogear-dev(a)lists.jboss.org <> >>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>>>> >>>>> _______________________________________________ >>>>> aerogear-dev mailing list >>>>> aerogear-dev(a)lists.jboss.org <> >>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>>>> >>>>> >>>>> >>>>> -- >>>>> Matthias Wessendorf >>>>> >>>>> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> >>>>> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> >>>>> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________... >>>>> aerogear-dev mailing list >>>>> aerogear-dev(a)lists.jboss.org <> >>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>>> _______________________________________________ >>>> aerogear-dev mailing list >>>> aerogear-dev(a)lists.jboss.org <> >>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>> _______________________________________________ >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org <> >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >> >> >> -- >> Sent from Gmail Mobile >> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> >> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> >> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> >> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> >> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> >> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> >> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________... >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Nov 14, 2014, at 2:35 PM, Matthias Wessendorf <matzew(a)apache.org&gt; wrote: so far so good :-) It's just been a bit busy the last weeks... I will do a detailed review, and tests next week. Sounds good? On Fri, Nov 14, 2014 at 6:58 PM, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: > On Nov 5, 2014, at 2:03 PM, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: > > so i wrote a little blog post on this, http://blog.lholmquist.org/safari-push-notifications/ <http://blog.lholmquist.org/safari-push-notifications/> > > > So i’ve made the iOSVariant an APNsVariant, but now i have a decision. > > currently on the safari-push branch, https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push <https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push>;, i’ve changed the UI to this: > > http://blog.lholmquist.org/content/images/2014/Nov/Screen_Shot_2014_11_05... <http://blog.lholmquist.org/content/images/2014/Nov/Screen_Shot_2014_11_05... > > where there is 1 variant to choose from for iOS and Safari. And not really and way to tell the difference if a variant is for safari or for iOS > > I’m wondering if there should be 2 selections that hit the same(update from ios) “apns" endpoint, and also a field on the APNsVariant to differentiate between iOS and Safari, i can see this as being something for analytics > any thoughts on this? > > If we agree to go this route, then we can do the same when we update the GCMVariant > > > > > > >> On Oct 30, 2014, at 9:13 AM, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: >> >> hmm, indeed, let me try that also >>> On Oct 30, 2014, at 2:57 AM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: >>> >>> I tried the same, again with -d (rhc -d), that worked fine.... >>> >>> >>> hrm... >>> >>> On Thu, Oct 30, 2014 at 7:48 AM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: >>> hahaha, than it disappeared ??? :-) >>> >>> looks like the 'delete' was triggered by the 504 ? >>> >>> On Thu, Oct 30, 2014 at 7:47 AM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: >>> Here is what I did, on command line: >>> rhc app create --no-git safari "https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/openshift-origin-cartridge-aerogear-push-wildfly&commit=086fe4f75f8991e7780c9df078c7371377c68aa2 <https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/open... >>> >>> >>> >>> One the console, I am getting: >>> Creating application 'safari' ... Server returned an unexpected error code: 504 >>> >>> >>> >>> >>> but.... well, here is the server -> https://safari-pushee.rhcloud.com/ag-push <https://safari-pushee.rhcloud.com/ag-push> >>> >>> >>> >>> What I do not understand it the 504 :) >>> >>> >>> >>> >>> >>> On Wed, Oct 29, 2014 at 10:01 PM, Matthias Wessendorf <matzew(a)apache.org <mailto:matzew@apache.org>> wrote: >>> any log from rhc client? >>> >>> >>> On Wednesday, October 29, 2014, Lucas Holmquist <lholmqui(a)redhat.com <mailto:lholmqui@redhat.com>> wrote: >>> i’ve created a safari-push branch on my fork of the open shift cartridge, >>> >>> https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wi... <https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wi... >>> >>> >>> i’ve been trying to create an app with it but haven’t been successful, perhaps something i’m doing, anyone mind giving it a try >>>> On Oct 28, 2014, at 3:35 PM, Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >>>> >>>> >>>> The branch on the main repo https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push <https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push> >>>> >>>> subsequent PR’s will target this one >>>> >>>>> On Oct 28, 2014, at 3:21 PM, Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >>>>> >>>>> Here is the initial addition in one of my branches: https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push <https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-pu... >>>>>> On Oct 27, 2014, at 9:42 AM, Matthias Wessendorf <matzew(a)apache.org <>> wrote: >>>>>> >>>>>> >>>>>> >>>>>> On Mon, Oct 27, 2014 at 2:28 PM, Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >>>>>> >>>>>>> On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <edewit(a)redhat.com <>> wrote: >>>>>>> >>>>>>> On 27 Oct,2014, at 14:15 , Lucas Holmquist <lholmqui(a)redhat.com <>> wrote: >>>>>>> >>>>>>>> >>>>>>>> So i’ve run into a bit of a problem, I’m trying to send notifications, using https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... <https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>>>>>>> >>>>>>>> but i’m not sure how to also tell it to use the new SafarVariant.class that i’ve created. >>>>>>> >>>>>>> Right now a sender is configured to send notifications for one specific variant type, this mapping is configured on the top of the class: >>>>>>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... <https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>>>>>> >>>>>>> so APNsPushNotificationSender will only be use for iOSVariant variants, so either we change the way this works or you create a new Sender ( that extends this one maybe ) >>>>>> >>>>>> I think i’ll just create a new sender of now just to get something working since the SafariVariant and iOSVariant will be combined into an APNsVariant in the near future. >>>>>> >>>>>> sounds reasonable on getting this started >>>>>> >>>>>> -M >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> Cheers, >>>>>>> Erik Jan >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> aerogear-dev mailing list >>>>>>> aerogear-dev(a)lists.jboss.org <> >>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>>>>> >>>>>> _______________________________________________ >>>>>> aerogear-dev mailing list >>>>>> aerogear-dev(a)lists.jboss.org <> >>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Matthias Wessendorf >>>>>> >>>>>> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> >>>>>> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> >>>>>> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________... >>>>>> aerogear-dev mailing list >>>>>> aerogear-dev(a)lists.jboss.org <> >>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>>>> _______________________________________________ >>>>> aerogear-dev mailing list >>>>> aerogear-dev(a)lists.jboss.org <> >>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>>> _______________________________________________ >>>> aerogear-dev mailing list >>>> aerogear-dev(a)lists.jboss.org <> >>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >>> >>> >>> -- >>> Sent from Gmail Mobile >>> >>> >>> >>> -- >>> Matthias Wessendorf >>> >>> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> >>> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> >>> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf> >>> >>> >>> -- >>> Matthias Wessendorf >>> >>> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> >>> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> >>> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf> >>> >>> >>> -- >>> Matthias Wessendorf >>> >>> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> >>> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> >>> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________... >>> aerogear-dev mailing list >>> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> >>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org <mailto:aerogear-dev@lists.jboss.org> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev> -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________... aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

Hey Luke, did a first review and also committed some minor tweaks to polish the comments. First round -> done On Fri, Nov 14, 2014 at 8:42 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: > yea, no problem, i was just wondering if there were thoughts on having 2 > selections or just 1. > > On Nov 14, 2014, at 2:35 PM, Matthias Wessendorf <matzew(a)apache.org&gt; > wrote: > > so far so good :-) > > It's just been a bit busy the last weeks... I will do a detailed review, > and tests next week. > Sounds good? > > On Fri, Nov 14, 2014 at 6:58 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; > wrote: > >> >> On Nov 5, 2014, at 2:03 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; wrote: >> >> so i wrote a little blog post on this, >> http://blog.lholmquist.org/safari-push-notifications/ >> >> >> So i’ve made the iOSVariant an APNsVariant, but now i have a decision. >> >> currently on the safari-push branch, >> https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push, >> i’ve changed the UI to this: >> >> >> http://blog.lholmquist.org/content/images/2014/Nov/Screen_Shot_2014_11_05... >> >> where there is 1 variant to choose from for iOS and Safari. And not >> really and way to tell the difference if a variant is for safari or for iOS >> >> I’m wondering if there should be 2 selections that hit the same(update >> from ios) “apns" endpoint, and also a field on the APNsVariant to >> differentiate between iOS and Safari, i can see this as being something >> for analytics >> >> any thoughts on this? >> >> >> If we agree to go this route, then we can do the same when we update >> the GCMVariant >> >> >> >> >> >> >> On Oct 30, 2014, at 9:13 AM, Lucas Holmquist <lholmqui(a)redhat.com&gt; >> wrote: >> >> hmm, indeed, let me try that also >> >> On Oct 30, 2014, at 2:57 AM, Matthias Wessendorf <matzew(a)apache.org&gt; >> wrote: >> >> I tried the same, again with -d (rhc -d), that worked fine.... >> >> >> hrm... >> >> On Thu, Oct 30, 2014 at 7:48 AM, Matthias Wessendorf <matzew(a)apache.org&gt; >> wrote: >> >>> hahaha, than it disappeared ??? :-) >>> >>> looks like the 'delete' was triggered by the 504 ? >>> >>> On Thu, Oct 30, 2014 at 7:47 AM, Matthias Wessendorf <matzew(a)apache.org >>> > wrote: >>> >>>> Here is what I did, on command line: >>>> rhc app create --no-git safari " >>>> https://cartreflect-claytondev.rhcloud.com/reflect?github=lholmquist/open... >>>> " >>>> >>>> >>>> >>>> One the console, I am getting: >>>> Creating application 'safari' ... Server returned an unexpected error >>>> code: 504 >>>> >>>> >>>> >>>> >>>> but.... well, here is the server -> >>>> https://safari-pushee.rhcloud.com/ag-push >>>> >>>> >>>> >>>> What I do not understand it the 504 :) >>>> >>>> >>>> >>>> >>>> >>>> On Wed, Oct 29, 2014 at 10:01 PM, Matthias Wessendorf < >>>> matzew(a)apache.org&gt; wrote: >>>> >>>>> any log from rhc client? >>>>> >>>>> >>>>> On Wednesday, October 29, 2014, Lucas Holmquist <lholmqui(a)redhat.com&gt; >>>>> wrote: >>>>> >>>>>> i’ve created a safari-push branch on my fork of the open shift >>>>>> cartridge, >>>>>> >>>>>> >>>>>> https://github.com/lholmquist/openshift-origin-cartridge-aerogear-push-wi... >>>>>> >>>>>> >>>>>> i’ve been trying to create an app with it but haven’t been >>>>>> successful, perhaps something i’m doing, anyone mind giving it a try >>>>>> >>>>>> On Oct 28, 2014, at 3:35 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; >>>>>> wrote: >>>>>> >>>>>> >>>>>> The branch on the main repo >>>>>> https://github.com/aerogear/aerogear-unifiedpush-server/tree/safari-push >>>>>> >>>>>> subsequent PR’s will target this one >>>>>> >>>>>> On Oct 28, 2014, at 3:21 PM, Lucas Holmquist <lholmqui(a)redhat.com&gt; >>>>>> wrote: >>>>>> >>>>>> Here is the initial addition in one of my branches: >>>>>> https://github.com/lholmquist/aerogear-unified-push-server/tree/safari-push >>>>>> >>>>>> On Oct 27, 2014, at 9:42 AM, Matthias Wessendorf <matzew(a)apache.org&gt; >>>>>> wrote: >>>>>> >>>>>> >>>>>> >>>>>> On Mon, Oct 27, 2014 at 2:28 PM, Lucas Holmquist < >>>>>> lholmqui(a)redhat.com&gt; wrote: >>>>>> >>>>>>> >>>>>>> On Oct 27, 2014, at 9:20 AM, Erik Jan de Wit <edewit(a)redhat.com&gt; >>>>>>> wrote: >>>>>>> >>>>>>> On 27 Oct,2014, at 14:15 , Lucas Holmquist <lholmqui(a)redhat.com&gt; >>>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> So i’ve run into a bit of a problem, I’m trying to send >>>>>>> notifications, using >>>>>>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>>>>>> >>>>>>> but i’m not sure how to also tell it to use the new >>>>>>> SafarVariant.class that i’ve created. >>>>>>> >>>>>>> >>>>>>> Right now a sender is configured to send notifications for one >>>>>>> specific variant type, this mapping is configured on the top of the class: >>>>>>> >>>>>>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/push/... >>>>>>> >>>>>>> so APNsPushNotificationSender will only be use for iOSVariant variants, >>>>>>> so either we change the way this works or you create a new Sender ( that >>>>>>> extends this one maybe ) >>>>>>> >>>>>>> >>>>>>> I think i’ll just create a new sender of now just to get something >>>>>>> working since the SafariVariant and iOSVariant will be combined into an >>>>>>> APNsVariant in the near future. >>>>>>> >>>>>> >>>>>> sounds reasonable on getting this started >>>>>> >>>>>> -M >>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Cheers, >>>>>>> Erik Jan >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> aerogear-dev mailing list >>>>>>> aerogear-dev(a)lists.jboss.org >>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>>>>> >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> aerogear-dev mailing list >>>>>>> aerogear-dev(a)lists.jboss.org >>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Matthias Wessendorf >>>>>> >>>>>> blog: http://matthiaswessendorf.wordpress.com/ >>>>>> sessions: http://www.slideshare.net/mwessendorf >>>>>> twitter: http://twitter.com/mwessendorf >>>>>> _______________________________________________ >>>>>> aerogear-dev mailing list >>>>>> aerogear-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> aerogear-dev mailing list >>>>>> aerogear-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> aerogear-dev mailing list >>>>>> aerogear-dev(a)lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev >>>>>> >>>>>> >>>>>> >>>>> >>>>> -- >>>>> Sent from Gmail Mobile >>>>> >>>> >>>> >>>> >>>> -- >>>> Matthias Wessendorf >>>> >>>> blog: http://matthiaswessendorf.wordpress.com/ >>>> sessions: http://www.slideshare.net/mwessendorf >>>> twitter: http://twitter.com/mwessendorf >>>> >>> >>> >>> >>> -- >>> Matthias Wessendorf >>> >>> blog: http://matthiaswessendorf.wordpress.com/ >>> sessions: http://www.slideshare.net/mwessendorf >>> twitter: http://twitter.com/mwessendorf >>> >> >> >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev