HI [~grdryn] ,
I believed that the changes performed in this PR make some the Prometheus Alerts stop to work. Note the changes performed here affect all project and it was not properly tested since it affects all project.
Note that if you change the rules and the API for all CR/CRDS as was done here we need to do a full regression test in the project and we need to cover for MSS for example:
- The monitoring and backup features
- Check if the APP will still be creating and deleting from the service with success which is - using the finaliser
- Check if as the `make uninstall` will still working well when has or not apps since it will use the finaliser as well.
Note that the same is valid for UPS and MDC as well.
I am testing it.
c/c Wei Li Ali Ok [~weil] [~aliok2] [~lrossett]
|
|
