| Our chat:
- Disconnected ()
<pbraun> Hi Ali <pbraun> i just saw that you took the ups config operator jira <aliok> yeah just had a quick look but the old code seemed weird to me <pbraun> the problem is that the watch channel can close <pbraun> and when that happens we need to call watch again <pbraun> that was the reason for the loop in the old code <aliok> then I think we somehow maintain channel's state in a var and don't call "watch" a million times <pbraun> but we dont <pbraun> https://github.com/aerogear/ups-config-operator/blob/7f6d93fc4d0148b4b42de69945cc6a2e65376491/cmd/server/main.go#L391 <aliok> ok, yeah. anyway, your explanation is good enough <pbraun> the call to watch loop blocks <pbraun> so only if the watch times out / terminates otherwise it will be called again <aliok> pbraun f*** right <aliok> ok. will convert that. <pbraun> it wasn't a problem during testing but it seems like a ticking bomb
|
|