Issue Type: Task Task
Affects Versions: 0.4.0
Assignee: Daniel Bevenius
Components: SimplePush-server
Created: 19/Jul/13 4:58 AM
Description:

Test will break with the latest version of Netty (currently 4.0.4.Final-SNAPSHOT). This task should fix these test failures:

websocketUnregister(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.052 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketUnregister(SimplePushSockJSServiceTest.java:211)

websocketHandleAcknowledgements(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.001 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketHandleAcknowledgements(SimplePushSockJSServiceTest.java:258)

websocketRegisterDuplicateChannelId(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.003 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketRegisterDuplicateChannelId(SimplePushSockJSServiceTest.java:199)

websocketHandleAcknowledgement(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.095 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketHandleAcknowledgement(SimplePushSockJSServiceTest.java:240)

websocketHello(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketHello(SimplePushSockJSServiceTest.java:175)

websocketUnregisterNonRegistered(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.138 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketUnregisterNonRegistered(SimplePushSockJSServiceTest.java:223)

websocketRegister(org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest)  Time elapsed: 0.01 sec  <<< ERROR!
java.lang.IllegalArgumentException: Response is expected to be of type TextWebSocketFrame was: UnpooledUnsafeDirectByteBuf(ridx: 0, widx: 3, cap: 64)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.responseToType(SimplePushSockJSServiceTest.java:385)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.sendWebSocketHelloFrame(SimplePushSockJSServiceTest.java:373)
        at org.jboss.aerogear.simplepush.server.netty.SimplePushSockJSServiceTest.websocketRegister(SimplePushSockJSServiceTest.java:186)

This was handled in the SockJS test by discarding empty responses for the websocket tests in question:

private Object readOutboundDiscardEmpty(final EmbeddedChannel ch) {
    final Object obj = ch.readOutbound();
    if (obj instanceof ByteBuf) {
        final ByteBuf buf = (ByteBuf) obj;
        if (buf.capacity() == 0) {
            ReferenceCountUtil.release(buf);
            return ch.readOutbound();
        }
    }
    return obj;
}
Fix Versions: 0.4.0
Project: AeroGear Push
Priority: Major Major
Reporter: Daniel Bevenius
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira