| paul wright i'm noting lot's of feedback items below. Some may not be relavant to this current JIRA so feel free to move them to the follow on JIRA to review/update these docs which is linked, just noting all issues that I spotted while doing a review. https://docs.aerogear.org/mobile-security/latest/index.html#apache-cordova - third image can be removed, this is an old representation of the user roles from keycloak. This screen is removed and the roles are shown in the second image. https://docs.aerogear.org/mobile-security/latest/index.html#apache-cordova - missing code block - scroll down to the 8th code block. https://docs.aerogear.org/mobile-security/latest/index.html#native-android - can that first image have the black background cropped out? looks inconsitent to the other images - reach out to Summers Pittman if you need a new image - not sure the 3rd and 4th image here are relevant to the section. Do we need to show accepting the cert in the user authentication section of the doc?
https://docs.aerogear.org/mobile-security/latest/index.html#android-2 same here with the black background https://docs.aerogear.org/mobile-security/latest/index.html#configuration - mobile-services.json config missing the keycloak config. It's just an empty file. paul wright I believe this is getting pulled from the ShowCase app which has on the empty configuration. May be better to hardcode an example in here? Small issue but there's 7 references to feedhenry in the document Xamarin Self Defence Checks Documentation is not included but not sure if this is necessary. |
