Some feedback for the aerogear-android-sdk:
# The documentation links in the README.md don't work (see PR)
# The links to the SDK docs (below) also don't work (see PR)
# Would it make sense to document the minimum required Android/SDK versions?
# When using Firebase you need google-services.json. This one has to be put in a different directory than mobile-services.json. Would it make sense to read both files from the same directory?
# This seems to be outdated: https://github.com/aerogear/aerogear-android-sdk/blob/master/docs/modules/ROOT/pages/push.adoc#registering-with-unified-push-server The new code should looke like:
{code}
push.registerDevice().requestOn(new AppExecutors().mainThread()).respondWith(new Responder<Boolean>() {
@Override
public void onResult(Boolean value) {...}
@Override
public void onException(Exception exception) {...}
});
{code}
(see PR)
# UPS and APB related: in UPS it's called a Google Key while in Firebase they just call it 'Server Key'. Should we rename it?
|
|
