Code format is very important in terms of code readability and maintainability and currently there is no solid mechanism to check it at the time of PR.
There is two steps:
# When coding
We need some tool that checks the code during coding time and that automatically format it, for example when saving or compiling.
Currently we are using http://eslint.org/ but the profile is very incomplete. We also could configure Grunt or NPM to run its formatter automatically.
# When sending a PR
We should have a tool that automatically checks code format before merging a PR. This might look redundant but the "developer side" could always have errors. A good option would be https://houndci.com.
h3. Verification steps:
Add few code styles mistakes to your code.
Send PR to aerogear project, your mistakes should be caught by ourr automated tool and reported in PR comments.
Run new code formatter locally and check that all mistakes were fixed. |
|
